Network traffic annotation added to common/cloud.

components/policy/core/common/cloud/external_policy_data_fetcher.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/policy/core/common/cloud/external_policy_data_fetcher.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/sequenced_task_runner.h"
 #include "base/stl_util.h"
 #include "components/data_use_measurement/core/data_use_user_data.h"
 #include "net/base/load_flags.h"
 #include "net/base/net_errors.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "net/url_request/url_request_status.h"
 
 namespace policy {
 
 namespace {
 
 // Helper that forwards the result of a fetch job from the thread that the
 // ExternalPolicyDataFetcherBackend runs on to the thread that the
@@ skipping 140 matching lines @@
 std::unique_ptr<ExternalPolicyDataFetcher>
 ExternalPolicyDataFetcherBackend::CreateFrontend(
     scoped_refptr<base::SequencedTaskRunner> task_runner) {
   return base::MakeUnique<ExternalPolicyDataFetcher>(
       task_runner, io_task_runner_, weak_factory_.GetWeakPtr());
 }
 
 void ExternalPolicyDataFetcherBackend::StartJob(
     ExternalPolicyDataFetcher::Job* job) {
   DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
-  std::unique_ptr<net::URLFetcher> owned_fetcher = net::URLFetcher::Create(
-      ++last_fetch_id_, job->url, net::URLFetcher::GET, this);
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("...", R"(
+        semantics {
+          sender: "..."

[pastarmovj, 2017/04/07 09:58:46]

Cloud Policy

[Ramin Halavati, 2017/04/19 05:21:57]

Done.

+          description: "..."

[Andrew T Wilson (Slow), 2017/04/18 12:01:31]

Used to fetch policy for extensions, policy-controlled wallpaper, and custom
terms of service.

[Ramin Halavati, 2017/04/19 05:21:58]

Done.

+          trigger: "..."

[Andrew T Wilson (Slow), 2017/04/18 12:01:31]

Periodically loaded when a managed user is signed in to Chrome.

[Ramin Halavati, 2017/04/19 05:21:58]

Done.

+          data: "..."

[Andrew T Wilson (Slow), 2017/04/18 12:01:31]

Various data, supplied by the admin for the managed user.

[Ramin Halavati, 2017/04/19 05:21:57]

Please elaborate.

[Andrew T Wilson (Slow), 2017/04/25 13:48:01]

This is used to fetch policy for extensions, which is part of the cloud policy
protocol for managed users. The data is generally freeform json based with no
fixed schema.

[Ramin Halavati, 2017/04/26 05:28:06]

Again, please confirm this is what this request sends.

[Andrew T Wilson (Slow), 2017/04/26 09:34:11]

This request sends no additional data - it is used to load external resources
provided by the admin via a unique URL.

[Ramin Halavati, 2017/04/26 09:44:41]

Done.

+          destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER

[pastarmovj, 2017/04/07 09:58:46]

GOOGLE_OWNED_SERVICE

[Ramin Halavati, 2017/04/19 05:21:58]

Done.

+        }
+        policy {
+          cookies_allowed: false/true

[pastarmovj, 2017/04/07 09:58:46]

true?

[Andrew T Wilson (Slow), 2017/04/18 12:01:31]

true

[Ramin Halavati, 2017/04/19 05:21:58]

Load flags disabled SAVE and SEND. Are they just loaded?

[Andrew T Wilson (Slow), 2017/04/25 13:48:01]

I don't think we use them here so feel free to mark this as false and/or disable
cookies in the associated request.

[Ramin Halavati, 2017/04/26 05:28:06]

Done.

+          cookies_store: "..."

[pastarmovj, 2017/04/07 09:58:46]

system?

[Andrew T Wilson (Slow), 2017/04/18 12:01:31]

system

[Ramin Halavati, 2017/04/19 05:21:58]

Acknowledged.

+          setting: "..."

[Andrew T Wilson (Slow), 2017/04/18 12:01:31]

none

[Ramin Halavati, 2017/04/19 05:21:58]

Done.

+          chrome_policy {

[pastarmovj, 2017/04/07 09:58:46]

empty?

[Andrew T Wilson (Slow), 2017/04/18 12:01:31]

empty

[Ramin Halavati, 2017/04/19 05:21:57]

Done.

+            [POLICY_NAME] {
+              policy_options {mode: MANDATORY/RECOMMENDED/UNSET}
+              [POLICY_NAME]: ... //(value to disable it)
+            }
+          }
+          policy_exception_justification: "..."

[pastarmovj, 2017/04/07 09:58:46]

This request is part of the policy fetcher itself.

[Ramin Halavati, 2017/04/19 05:21:57]

Done.

+        })");
+  std::unique_ptr<net::URLFetcher> owned_fetcher =
+      net::URLFetcher::Create(++last_fetch_id_, job->url, net::URLFetcher::GET,
+                              this, traffic_annotation);
   net::URLFetcher* fetcher = owned_fetcher.get();
   data_use_measurement::DataUseUserData::AttachToFetcher(
       fetcher, data_use_measurement::DataUseUserData::POLICY);
   fetcher->SetRequestContext(request_context_.get());
   fetcher->SetLoadFlags(net::LOAD_BYPASS_CACHE | net::LOAD_DISABLE_CACHE |
                         net::LOAD_DO_NOT_SAVE_COOKIES |
                         net::LOAD_DO_NOT_SEND_COOKIES |
                         net::LOAD_DO_NOT_SEND_AUTH_DATA);
   fetcher->SetAutomaticallyRetryOnNetworkChanges(3);
   fetcher->Start();
@@ skipping 74 matching lines @@
   ExternalPolicyDataFetcher::Job* job = it->second.job;
   int64_t max_size = job->max_size;
   if (current > max_size || total > max_size) {
     job_map_.erase(it);
     job->callback.Run(job, ExternalPolicyDataFetcher::MAX_SIZE_EXCEEDED,
                       std::unique_ptr<std::string>());
   }
 }
 
 }  // namespace policy