Issue 280063003: Re-land of have apply_patch.py/checkout.py stage git patches instead of committing them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 280063003: Re-land of have apply_patch.py/checkout.py stage git patches instead of committing them (Closed)

Created:
6 years, 7 months ago by hinoka

Modified:
6 years, 7 months ago

Reviewers:
Ryan Tseng, iannucci, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Re-land of have apply_patch.py/checkout.py stage git patches instead of committing them For a bot_update Git world, we don't really want to commit patches. Instead we just want to leave them unstaged. BUG=370503 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=269489

Patch Set 1 #

Patch Set 2 : Re-add deprecated flags #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -39 lines)			Patch
M	apply_issue.py	View	1	3 chunks	+3 lines, -8 lines	0 comments	Download
M	checkout.py	View		8 chunks	+12 lines, -29 lines	0 comments	Download
M	tests/checkout_test.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ryan Tseng

Added the --base_ref back in so bot_update doesn't explode when it tries to call apply_issue.py ...

6 years, 7 months ago (2014-05-10 02:15:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@chromium.org/280063003/20001

6 years, 7 months ago (2014-05-10 02:17:41 UTC) #4

Message was sent while issue was closed.

Change committed as 269489

Expand Messages | Collapse Messages