Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 280063002: Fix the compile error for win64: widevine_key_systems.cc. (Closed)

Created:
6 years, 7 months ago by ycheo (away)
Modified:
6 years, 7 months ago
Reviewers:
xhwang, ddorwin, dxie
CC:
chromium-reviews
Visibility:
Public.

Description

Fix the compile error for win64: widevine_key_systems.cc. BUG=372069 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269677

Patch Set 1 #

Total comments: 2

Patch Set 2 : Replace 0 with 0u for size_t. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/cdm/renderer/widevine_key_systems.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ycheo (away)
6 years, 7 months ago (2014-05-09 23:42:23 UTC) #1
ddorwin
Was this the result of your refactoring? This code is the same as before you ...
6 years, 7 months ago (2014-05-09 23:51:46 UTC) #2
xhwang
lgtm https://codereview.chromium.org/280063002/diff/1/components/cdm/renderer/widevine_key_systems.cc File components/cdm/renderer/widevine_key_systems.cc (right): https://codereview.chromium.org/280063002/diff/1/components/cdm/renderer/widevine_key_systems.cc#newcode27 components/cdm/renderer/widevine_key_systems.cc:27: DCHECK_GT(last_period, 0); s/0/0u?
6 years, 7 months ago (2014-05-09 23:59:22 UTC) #3
ycheo (away)
I have no idea why it is just started failing. I've just notified from dxie@. ...
6 years, 7 months ago (2014-05-10 00:03:45 UTC) #4
ycheo (away)
On 2014/05/10 00:03:45, Yuncheol Heo wrote: > I have no idea why it is just ...
6 years, 7 months ago (2014-05-10 00:13:00 UTC) #5
ycheo (away)
The CQ bit was checked by ycheo@chromium.org
6 years, 7 months ago (2014-05-10 08:18:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ycheo@chromium.org/280063002/20001
6 years, 7 months ago (2014-05-10 08:21:00 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 01:27:00 UTC) #8
Message was sent while issue was closed.
Change committed as 269677

Powered by Google App Engine
This is Rietveld 408576698