Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1179)

Issue 2800583002: move fasta.Keyword methods to analyzer.Keyword (Closed)

Created:
3 years, 8 months ago by danrubel
Modified:
3 years, 6 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -32 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/keyword.dart View 4 chunks +6 lines, -21 lines 0 comments Download
M pkg/front_end/lib/src/scanner/token.dart View 1 chunk +32 lines, -6 lines 0 comments Download
M pkg/front_end/test/token_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
danrubel
3 years, 8 months ago (2017-04-05 01:17:08 UTC) #2
Paul Berry
lgtm
3 years, 8 months ago (2017-04-05 15:54:54 UTC) #3
danrubel
Committed patchset #1 (id:1) manually as a37046227442564be464496ccc8300e1d6f96446 (presubmit successful).
3 years, 8 months ago (2017-04-05 17:51:59 UTC) #5
ahe
3 years, 6 months ago (2017-06-01 14:08:53 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698