Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc

Issue 2800473002: Treat responses with legacy LoFi headers as LoFi images. (Closed)
Patch Set: Rebased on master Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc
diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc b/components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc
index cba90e139d2ca891f9a957e7d3f090c26be56990..2e10c016f9eff4b7c89a9e6b5cb388d127a40f7d 100644
--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc
+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_headers_unittest.cc
@@ -77,6 +77,28 @@ TEST_F(DataReductionProxyHeadersTest, IsEmptyImagePreview) {
"Another-Header: empty-image\n",
false,
},
+ {
+ "HTTP/1.1 200 OK\n"
+ "Chrome-Proxy: q=low\n",
+ true,
+ },
+ {
+ "HTTP/1.1 200 OK\n"
+ "Chrome-Proxy: foo=bar, Q=LOW\n",
+ true,
+ },
+ {
+ "HTTP/1.1 200 OK\n"
+ "Chrome-Proxy-Content-Transform: q=low\n"
+ "Chrome-Proxy: empty-image\n",
+ false,
+ },
+ {
+ "HTTP/1.1 200 OK\n"
+ "Chrome-Proxy-Content-Transform: foo\n"
+ "Chrome-Proxy: q=low\n",
+ true,
+ },
};
for (size_t i = 0; i < arraysize(tests); ++i) {
std::string headers(tests[i].headers);
@@ -89,30 +111,30 @@ TEST_F(DataReductionProxyHeadersTest, IsEmptyImagePreview) {
TEST_F(DataReductionProxyHeadersTest, IsEmptyImagePreviewValue) {
const struct {
- const char* header;
+ const char* chrome_proxy_content_transform_header;
+ const char* chrome_proxy_header;
bool expected_result;
} tests[] = {
- {
- "foo", false,
- },
- {
- "", false,
- },
- {
- "empty-image", true,
- },
- {
- "empty-image;foo", true,
- },
- {
- "Empty-Image", true,
- },
- {
- "foo;empty-image", false,
- },
+ {"", "", false},
+ {"foo", "", false},
+ {"", "bar", false},
+ {"foo", "bar", false},
+ {"empty-image", "", true},
+ {"empty-image;foo", "", true},
+ {"Empty-Image", "", true},
+ {"foo;empty-image", "", false},
+ {"empty-image", "foo", true},
+ {"foo;empty-image", "bar", false},
+ {"", "q=low", true},
+ {"foo", "q=low", true},
+ {"foo", "bar, baz, Q=LOW ", true},
+ {"empty-image", "q=low", true},
};
- for (size_t i = 0; i < arraysize(tests); ++i)
- EXPECT_EQ(tests[i].expected_result, IsEmptyImagePreview(tests[i].header));
+ for (const auto& test : tests) {
+ EXPECT_EQ(test.expected_result,
+ IsEmptyImagePreview(test.chrome_proxy_content_transform_header,
+ test.chrome_proxy_header));
+ }
}
TEST_F(DataReductionProxyHeadersTest, IsLitePagePreview) {

Powered by Google App Engine
This is Rietveld 408576698