Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10921)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 2800473002: Treat responses with legacy LoFi headers as LoFi images. (Closed)
Patch Set: Added comment describing CPCT header format Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 77fd3cadaba22631c2b2c6b4747a090a3ef09c0f..0b0de3397edea18333fa5a8aaed3d76952122c9f 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -1384,13 +1384,16 @@ void ChromeContentRendererClient::AddImageContextMenuProperties(
const WebURLResponse& response,
std::map<std::string, std::string>* properties) {
DCHECK(properties);
- WebString header_key(WebString::fromASCII(
+
+ WebString cpct_value = response.httpHeaderField(WebString::fromASCII(
Lei Zhang 2017/04/08 01:01:07 Why do we have to go from const char* to WebString
sclittle 2017/04/10 20:56:50 We basically want to call: drp::IsEmptyImagePrevi
data_reduction_proxy::chrome_proxy_content_transform_header()));
- if (!response.httpHeaderField(header_key).isNull() &&
- data_reduction_proxy::IsEmptyImagePreview(
- response.httpHeaderField(header_key).utf8())) {
- (*properties)[
- data_reduction_proxy::chrome_proxy_content_transform_header()] =
+ WebString chrome_proxy_value = response.httpHeaderField(
+ WebString::fromASCII(data_reduction_proxy::chrome_proxy_header()));
+
+ if (data_reduction_proxy::IsEmptyImagePreview(cpct_value.utf8(),
+ chrome_proxy_value.utf8())) {
+ (*properties)
+ [data_reduction_proxy::chrome_proxy_content_transform_header()] =
data_reduction_proxy::empty_image_directive();
}
}
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698