Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2800463002: Gracefully handle if loaded dill program has no mainMethod set. (Closed)

Created:
3 years, 8 months ago by Emily Fortuna
Modified:
3 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Gracefully handle if loaded dill program has no mainMethod set. BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/b24e594ebd56d58546350cff69536750a912ebb9

Patch Set 1 #

Patch Set 2 : .. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M pkg/compiler/lib/src/library_loader.dart View 1 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Emily Fortuna
This is actually a small change. I'll rebase as soon as I check in https://codereview.chromium.org/2798443002/ ...
3 years, 8 months ago (2017-04-04 20:16:20 UTC) #2
Johnni Winther
lgtm
3 years, 8 months ago (2017-04-05 06:48:04 UTC) #4
Emily Fortuna
3 years, 8 months ago (2017-04-05 19:35:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
b24e594ebd56d58546350cff69536750a912ebb9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698