Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2800453002: Remove _StdSink._isTranslatable field. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
zra, Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove _StdSink._isTranslatable field. The field is not used since https://github.com/dart-lang/sdk/commit/141b6351baacaedf23e740b5b7354970f2ac0979, but it is final and not initialized, so this causes an error during analyzer tests. R=paulberry@google.com, zra@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/565408593bb7521452c82992405e05fd47754bfe

Patch Set 1 #

Patch Set 2 : Update DDC expections. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M pkg/dev_compiler/tool/sdk_expected_errors.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/io/stdio.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 8 months ago (2017-04-04 19:29:20 UTC) #1
Paul Berry
lgtm
3 years, 8 months ago (2017-04-04 19:43:23 UTC) #2
zra
lgtm
3 years, 8 months ago (2017-04-04 19:44:05 UTC) #3
scheglov
3 years, 8 months ago (2017-04-04 19:56:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
565408593bb7521452c82992405e05fd47754bfe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698