Build elements for FieldFormalParameter(s) even for local functions.

Build elements for FieldFormalParameter(s) even for local functions.

This is invalid code, we report an error, but we cannot leave it as
null, because this causes exceptions down the stream.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/16e96415836e76fd4883a2f5d78e4be133619dcf

[Paul Berry, 2017-04-04 19:12:24]

lgtm

[scheglov, 2017-04-04 19:45:17]

Description was changed from

==========
Build elements for FieldFormalParameter(s) even for local functions.

This is invalid code, we report an error, but we cannot leave it as
null, because this causes exceptions down the stream.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Build elements for FieldFormalParameter(s) even for local functions.

This is invalid code, we report an error, but we cannot leave it as
null, because this causes exceptions down the stream.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/16e96415836e76fd4883a2f5d78e4be133619dcf
==========

[scheglov, 2017-04-04 19:45:18]

Committed patchset #1 (id:1) manually as
16e96415836e76fd4883a2f5d78e4be133619dcf (presubmit successful).

[Brian Wilkerson, 2017-04-04 20:00:34]

I know I'm tired, but I honestly can't see what changed between the two versions
of builder.dart. It probably doesn't matter, though, given that Paul looked it
over.

https://codereview.chromium.org/2800443002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/builder.dart (right):

https://codereview.chromium.org/2800443002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/builder.dart:1426: Object
visitFieldFormalParameter(FieldFormalParameter node) {
What's up with the sort order? This method shouldn't have been moved.

[scheglov, 2017-04-04 20:02:29]

https://codereview.chromium.org/2800443002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/builder.dart (right):

https://codereview.chromium.org/2800443002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/builder.dart:1426: Object
visitFieldFormalParameter(FieldFormalParameter node) {
On 2017/04/04 20:00:34, Brian Wilkerson wrote:
> What's up with the sort order? This method shouldn't have been moved.

I moved it manually from one class (ApiElementBuilder) to its superclass
(_BaseElementBuilder) :-)

[Brian Wilkerson, 2017-04-04 20:11:56]

lgtm

https://codereview.chromium.org/2800443002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/builder.dart (right):

https://codereview.chromium.org/2800443002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/builder.dart:1426: Object
visitFieldFormalParameter(FieldFormalParameter node) {
And unlike 'git diff', this tool doesn't provide that context. I guess I should
have noticed that 1174 lines were skipped. :-) Thanks!