Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 280043002: Use Async readbacks in the SoftwareRenderer unit tests. (Closed)

Created:
6 years, 7 months ago by danakj
Modified:
6 years, 7 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, piman
Visibility:
Public.

Description

Use Async readbacks in the SoftwareRenderer unit tests. These tests are pixel tests and are using GetFramebufferPixels which will go away with CompositeAndReadback. R=enne BUG=251936 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269665

Patch Set 1 : nocnr-software-renderer-tests: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -106 lines) Patch
M cc/output/software_renderer_unittest.cc View 7 chunks +105 lines, -106 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danakj
6 years, 7 months ago (2014-05-09 22:41:52 UTC) #1
enne (OOO)
lgtm
6 years, 7 months ago (2014-05-09 22:52:48 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-09 22:56:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/280043002/1
6 years, 7 months ago (2014-05-09 23:01:42 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 00:57:32 UTC) #5
Message was sent while issue was closed.
Change committed as 269665

Powered by Google App Engine
This is Rietveld 408576698