Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp

Issue 2800393003: This CL is a workaround fix for a crash issue; to set "undefined" instead of deleting properties. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
index f684590795a1d4745a56b24d64e0f5f533514e30..230d6a019d9aca47eed4af978d4ad9da858e08ff 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
@@ -161,8 +161,8 @@ void ScriptPromisePropertyBase::ClearWrappers() {
++i) {
v8::Local<v8::Object> wrapper = (*i)->NewLocal(isolate_);
if (!wrapper.IsEmpty()) {
- ResolverSymbol().DeleteProperty(wrapper);
// TODO(peria): Use deleteProperty() if http://crbug.com/v8/6227 is fixed.
+ ResolverSymbol().Set(wrapper, v8::Undefined(isolate_));
PromiseSymbol().Set(wrapper, v8::Undefined(isolate_));
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698