[Notifications] Drop tap gestures for ArcCustomNotificationView.

ui/arc/notification/arc_custom_notification_view.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/arc/notification/arc_custom_notification_view.h"
 
 #include "ash/wm/window_util.h"
 #include "base/auto_reset.h"
 #include "base/memory/ptr_util.h"
 #include "components/exo/notification_surface.h"
@@ skipping 26 matching lines @@
   // ui::EventHandler
   void OnEvent(ui::Event* event) override {
     // Do not forward event targeted to the floating close button so that
     // keyboard press and tap are handled properly.
     if (owner_->floating_control_buttons_widget_ && event->target() &&
         owner_->floating_control_buttons_widget_->GetNativeWindow() ==
             event->target()) {
       return;
     }
 
+    // Tap gestures are handled on the Android side, so drop them here.
+    // See crbug.com/709911.
+    if (event->type() == ui::ET_GESTURE_TAP) {
+      return;
+    }
+
     if (event->IsScrollEvent()) {
       ForwardScrollEvent(event->AsScrollEvent());
     } else if (event->IsMouseWheelEvent()) {
       ForwardMouseWheelEvent(event->AsMouseWheelEvent());
     } else if (!event->IsTouchEvent()) {

[yhanada, 2017/04/10 09:18:13]

How about adding |event->type() != ui::ET_GESTURE_TAP| here and updating the
comments below?

[Eliot Courtney, 2017/04/11 06:27:21]

Done.

       // TODO(yoshiki): Use a better tigger (eg. focusing EditText on
       // notification) than clicking (crbug.com/697379).
       if (event->type() == ui::ET_MOUSE_PRESSED)
         owner_->ActivateToast();
 
       // Forward the rest events to |owner_| except touches because View
       // should no longer receive touch events. See View::OnTouchEvent.
       owner_->OnEvent(event);
     }
   }
@@ skipping 555 matching lines @@
 
 void ArcCustomNotificationView::OnNotificationSurfaceRemoved(
     exo::NotificationSurface* surface) {
   if (surface->notification_id() != notification_key_)
     return;
 
   SetSurface(nullptr);
 }
 
 }  // namespace arc