Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 2800343004: Add histograms for animated image types

Created:
3 years, 8 months ago by scroggo_chromium
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, jzern, krit, drott+blinkwatch_chromium.org, urvang, blink-reviews-platform-graphics_chromium.org, skal, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, fmalita+watch_chromium.org, Rik, Stephen Chennney, Justin Novosad, asvitkine+watch_chromium.org, blink-reviews, kinuko+watch, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add histograms for animated image types Add histograms to compare the usage of image types used for animation. Include the three we support (GIF, WEBP, and PNG). In WEBP and PNG log the type once we know the size, since we are guaranteed to know that the image is animated at that point. In GIF, log the type once the start of a second frame is parsed, since before that there is no way to know whether the image is animated. In all three cases, an image will be logged twice, assuming that deferred decoding is used and the image is decoded in the background thread. (i.e. if the main thread decodes the size/frame count, but the image is never decoded, the image will only be logged once.) For PNG, this ignores images which were intended to be APNGs, but includes images which are APNGs with only one frame, even though they are not "animated" (such images are used to behave differently depending on whether a browser supports APNG). BUG=704425

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.h View 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp View 2 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +14 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698