Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 280033002: ozone: Make the evdev implementation a PlatformEventSource. (Closed)

Created:
6 years, 7 months ago by sadrul
Modified:
6 years, 7 months ago
Reviewers:
rjkroege, spang
CC:
chromium-reviews, rjkroege, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org
Visibility:
Public.

Description

ozone: Make the evdev implementation a PlatformEventSource. Instead of using the EventFactoryOzone as the PlatformEventSource, allow ozone's platform implementation to decide what to use as the event-source. For the evdev ozone-platform, the event-factory (EventFactoryEvdev) remains as the event source. In the case of X11 ozone-platform, it will create the X11EventSource (currently used on chromeos and linux-aura) as the event-source. BUG=361137 R=spang@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M ui/events/ozone/evdev/event_factory_evdev.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/event_factory_ozone.h View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sadrul
6 years, 7 months ago (2014-05-09 22:23:37 UTC) #1
rjkroege
on the face of it, this change seems fine but the build bot result looks ...
6 years, 7 months ago (2014-05-12 12:35:17 UTC) #2
sadrul
On 2014/05/12 12:35:17, rjkroege wrote: > on the face of it, this change seems fine ...
6 years, 7 months ago (2014-05-12 15:22:31 UTC) #3
spang
lgtm
6 years, 7 months ago (2014-05-12 16:31:13 UTC) #4
sadrul
6 years, 7 months ago (2014-05-12 17:43:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r269808 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698