ios/clean/chrome/browser/ui/root/root_coordinator_unittest.mm - Issue 2800313002: [ios] RootCoordinator and view controller.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/root/root_coordinator_unittest.mm

Issue 2800313002: [ios] RootCoordinator and view controller. (Closed)

Patch Set: Unittests, showcase, and clean up. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #import "ios/clean/chrome/browser/ui/root/root_coordinator.h"

	6

	7 #import "ios/clean/chrome/browser/url_opening.h"

	8 #include "testing/gtest/include/gtest/gtest.h"

	9

	10 #if !defined(__has_feature) \|\| !__has_feature(objc_arc)

	11 #error "This file requires ARC support."

	12 #endif

	13

	14 namespace {

	15

	16 // Tests that RootCoordinator conforms to the URLOpening protocol.

	17 TEST(RootCoordinatorTest, TestConformsToURLOpening) {

	18 EXPECT_TRUE([RootCoordinator conformsToProtocol:@protocol(URLOpening)]);

	19 }

	20
	lpromero 2017/04/12 08:58:49 You could add a test that starting the coordinator You could add a test that starting the coordinator installs a contentViewController on its controller? openURL: is harder to test though. edchin 2017/04/13 07:39:15 In order to test the coordinator's start method, Show quoted text On 2017/04/12 08:58:49, lpromero wrote: > You could add a test that starting the coordinator installs a > contentViewController on its controller? > > openURL: is harder to test though. In order to test the coordinator's start method, we need a real browser state. I'll create more tests once we have better examples of coordinator unittests.
	21 } // namespace

OLD	NEW