ios/clean/chrome/app/steps/root_coordinator+application_step.h - Issue 2800313002: [ios] RootCoordinator and view controller.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/app/steps/root_coordinator+application_step.h

Issue 2800313002: [ios] RootCoordinator and view controller. (Closed)

Patch Set: Unittests, showcase, and clean up. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ios/clean/chrome/app/steps/BUILD.gn ('k') | ios/clean/chrome/app/steps/root_coordinator+application_step.mm » ('j') | ios/clean/chrome/browser/ui/root/root_container_view_controller_unittest.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CLEAN_CHROME_APP_STEPS_ROOT_COORDINATOR_APPLICATION_STEP_H_

	6 #define IOS_CLEAN_CHROME_APP_STEPS_ROOT_COORDINATOR_APPLICATION_STEP_H_

	7

	8 #import "ios/clean/chrome/app/application_step.h"

	9 #import "ios/clean/chrome/browser/ui/root/root_coordinator.h"

	10

	11 // Category on RootCoordinator to allow it to act as an application

	12 // step and control the root UI for the application when is starts.

	13 // Creates the main window and makes it key, but doesn't make it visible yet.
	lpromero 2017/04/12 08:58:49 Maybe this is an assumption that could be unit-tes Maybe this is an assumption that could be unit-tested? edchin 2017/04/13 07:39:15 Additional tests are added, but this whole assumpt Show quoted text On 2017/04/12 08:58:49, lpromero wrote: > Maybe this is an assumption that could be unit-tested? Additional tests are added, but this whole assumption is not unit tested. We need a real browser state in order to test this better. I will update with more tests once we have better examples of coordinator unittests.
	14 // Pre: Application phase is APPLICATION_FOREGROUNDED and the main window is

	15 // key.

	16 // Post: Application phase is (still) APPLICATION_FOREGROUNDED, the main window

	17 // is visible and has a root view controller set.

	18 @interface RootCoordinator (ApplicationStep)<ApplicationStep>

	19 @end

	20

	21 #endif // IOS_CLEAN_CHROME_APP_STEPS_ROOT_COORDINATOR_APPLICATION_STEP_H_

OLD	NEW