ios/clean/chrome/browser/ui/root/root_container_view_controller.h - Issue 2800313002: [ios] RootCoordinator and view controller.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/root/root_container_view_controller.h

Issue 2800313002: [ios] RootCoordinator and view controller. (Closed)

Patch Set: Address comments. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_ROOT_ROOT_CONTAINER_VIEW_CONTROLLER_H_

	6 #define IOS_CLEAN_CHROME_BROWSER_UI_ROOT_ROOT_CONTAINER_VIEW_CONTROLLER_H_

	7

	8 #import <UIKit/UIKit.h>

	9

	10 #import "ios/clean/chrome/browser/ui/animators/zoom_transition_delegate.h"

	11

	12 // View controller that wholly contains a content view controller.
	lpromero 2017/04/11 15:20:39 Does it make sense to add this view controller to Does it make sense to add this view controller to Showcase? edchin 2017/04/11 15:52:05 Yes it does. Will do. Show quoted text On 2017/04/11 15:20:39, lpromero wrote: > Does it make sense to add this view controller to Showcase? Yes it does. Will do. edchin 2017/04/12 08:10:52 Done. Show quoted text On 2017/04/11 15:20:39, lpromero wrote: > Does it make sense to add this view controller to Showcase? Done.
	13 @interface RootContainerViewController

	14 : UIViewController<ZoomTransitionDelegate>

	15

	16 // View controller showing the main content.

	17 @property(nonatomic, weak) UIViewController* contentViewController;

	18

	19 @end

	20

	21 #endif // IOS_CLEAN_CHROME_BROWSER_UI_ROOT_ROOT_CONTAINER_VIEW_CONTROLLER_H_

OLD	NEW