ios/clean/chrome/browser/ui/root/root_container_coordinator.h - Issue 2800313002: [ios] RootCoordinator and view controller.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/root/root_container_coordinator.h

Issue 2800313002: [ios] RootCoordinator and view controller. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_ROOT_ROOT_CONTAINER_COORDINATOR_H_

	6 #define IOS_CLEAN_CHROME_BROWSER_UI_ROOT_ROOT_CONTAINER_COORDINATOR_H_

	7

	8 #import "ios/clean/chrome/browser/url_opening.h"

	9 #import "ios/shared/chrome/browser/ui/coordinators/browser_coordinator.h"

	10

	11 // Coordinator that runs the root container.

	12 @interface RootContainerCoordinator : BrowserCoordinator<URLOpening>
	marq (ping after 24h) 2017/04/10 11:04:25 Naming nitpicks: I think just "RootCoordinator" is Naming nitpicks: I think just "RootCoordinator" is better, since the fact that it uses containment is an implementation detail (this is why we have TabCoordinator vs. TabContainerViewController). edchin 2017/04/10 16:41:28 Naming collision: https://cs.chromium.org/chromium Show quoted text On 2017/04/10 11:04:25, marq wrote: > Naming nitpicks: I think just "RootCoordinator" is better, since the fact that > it uses containment is an implementation detail (this is why we have > TabCoordinator vs. TabContainerViewController). Naming collision: https://cs.chromium.org/chromium/src/ios/chrome/browser/root_coordinator.h?dr...
	13 @end

	14

	15 #endif // IOS_CLEAN_CHROME_BROWSER_UI_ROOT_ROOT_CONTAINER_COORDINATOR_H_

OLD	NEW