updates to the analysis server generated spec doc

pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart

Index: pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart
diff --git a/pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart b/pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart
index 7fa830686158e95bb54bf50296a2a6ca98c37b3a..b21c8e38558d0fc38dc007e18bd7bb2f113de07d 100644
--- a/pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart
+++ b/pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart
@@ -9174,14 +9174,14 @@ class AnalysisOptions implements HasToJson {
   bool _generateLints;
 
   /**
-   * Deprecated: this feature is always enabled.
+   * @deprecated: this feature is always enabled.

[Brian Wilkerson, 2017/04/09 16:30:53]

Personally, I like the old style better. I don't think the at sign adds any
value either here or in the specification, despite the similarity to the
annotation. This isn't Dart; it just adds one more special character to have to
parse while reading it. You replaced a pair or parentheses with a colon, which I
assume is to make the text visually less bulky, so I don't understand adding an
extra character here when it has the opposite effect.

That said, it would be interesting to consider adding the actual annotation to
the generated code:

/**
 * Deprecated: this feature is always enabled.
 *
 * True if the client wants to enable support for the proposed async feature.
 */
@deprecated
bool get enableAsync => _enableAsync;

This might result in a lot of extraneous hints in the analysis_server package,
though, because we still have to reference these members until we actually
remove them from the API.

[devoncarew, 2017/04/09 19:43:21]

Sure, I moved back to the 'Deprecated:' text. Will experiment with actual
@deprected annotations in the generated libraries.
That change was because the properties looked a bit like method declarations to
me; I think the 'foo: String' rendering is a little less confusing.

    *
    * True if the client wants to enable support for the proposed async feature.
    */
   bool get enableAsync => _enableAsync;
 
   /**
-   * Deprecated: this feature is always enabled.
+   * @deprecated: this feature is always enabled.
    *
    * True if the client wants to enable support for the proposed async feature.
    */
@@ -9190,7 +9190,7 @@ class AnalysisOptions implements HasToJson {
   }
 
   /**
-   * Deprecated: this feature is always enabled.
+   * @deprecated: this feature is always enabled.
    *
    * True if the client wants to enable support for the proposed deferred
    * loading feature.
@@ -9198,7 +9198,7 @@ class AnalysisOptions implements HasToJson {
   bool get enableDeferredLoading => _enableDeferredLoading;
 
   /**
-   * Deprecated: this feature is always enabled.
+   * @deprecated: this feature is always enabled.
    *
    * True if the client wants to enable support for the proposed deferred
    * loading feature.
@@ -9208,14 +9208,14 @@ class AnalysisOptions implements HasToJson {
   }
 
   /**
-   * Deprecated: this feature is always enabled.
+   * @deprecated: this feature is always enabled.
    *
    * True if the client wants to enable support for the proposed enum feature.
    */
   bool get enableEnums => _enableEnums;
 
   /**
-   * Deprecated: this feature is always enabled.
+   * @deprecated: this feature is always enabled.
    *
    * True if the client wants to enable support for the proposed enum feature.
    */
@@ -9224,7 +9224,7 @@ class AnalysisOptions implements HasToJson {
   }
 
   /**
-   * Deprecated: this feature is always enabled.
+   * @deprecated: this feature is always enabled.
    *
    * True if the client wants to enable support for the proposed "null aware
    * operators" feature.
@@ -9232,7 +9232,7 @@ class AnalysisOptions implements HasToJson {
   bool get enableNullAwareOperators => _enableNullAwareOperators;
 
   /**
-   * Deprecated: this feature is always enabled.
+   * @deprecated: this feature is always enabled.
    *
    * True if the client wants to enable support for the proposed "null aware
    * operators" feature.
@@ -11108,13 +11108,13 @@ class ElementKind implements Enum {
       const ElementKind._("TYPE_PARAMETER");
 
   /**
-   * Deprecated: support for tests was removed.
+   * @deprecated: support for tests was removed.
    */
   static const ElementKind UNIT_TEST_GROUP =
       const ElementKind._("UNIT_TEST_GROUP");
 
   /**
-   * Deprecated: support for tests was removed.
+   * @deprecated: support for tests was removed.
    */
   static const ElementKind UNIT_TEST_TEST =
       const ElementKind._("UNIT_TEST_TEST");