chromeos/dbus/fake_shill_manager_client.h - Issue 280023003: Implement networkingPrivate.getNetworks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/fake_shill_manager_client.h

Issue 280023003: Implement networkingPrivate.getNetworks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix tests (sort ServiceCompleteList) Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/fake_shill_manager_client.h

diff --git a/chromeos/dbus/fake_shill_manager_client.h b/chromeos/dbus/fake_shill_manager_client.h

index 339e0d16b8845889f2a911c8f7c95a70fc3d47e0..85be53a06a0d48461e5148b6efc893f3cef5346d 100644

--- a/chromeos/dbus/fake_shill_manager_client.h

+++ b/chromeos/dbus/fake_shill_manager_client.h

@@ -105,6 +105,7 @@ class CHROMEOS_EXPORT FakeShillManagerClient

virtual int GetInteractiveDelay() const OVERRIDE;

private:

+ void SortServiceList(const std::string& property);

pneubeck (no reviews) 2014/05/15 18:28:37 optional nit: add a comment; also that |property|

stevenjb 2014/05/15 20:12:41 Done.

void AddServiceToWatchList(const std::string& service_path);

void SetDefaultProperties();

void PassStubProperties(const DictionaryValueCallback& callback) const;