chrome/browser/extensions/api/networking_private/networking_private_apitest.cc - Issue 280023003: Implement networkingPrivate.getNetworks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

Issue 280023003: Implement networkingPrivate.getNetworks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_api_nonchromeos.cc ('k') | chrome/browser/resources/chromeos/network_configuration/js/network_status.js » ('j') | chrome/test/data/extensions/api_test/networking/test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc b/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

index 3e91bb1fbc3c62c2f50658956ab704aeabcd4551..cf9eb03e0689836e4defe26442c290d95269265e 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

@@ -392,7 +392,14 @@ IN_PROC_BROWSER_TEST_P(ExtensionNetworkingPrivateApiTest,

}

#if defined(OS_CHROMEOS)

-// Non-Chrome OS only supports wifi currently.

+// TODO(stevenjb/mef): Fix these on non-Chrome OS, crbug.com/371442.

+IN_PROC_BROWSER_TEST_P(ExtensionNetworkingPrivateApiTest, GetNetworks) {

+ // Add a couple of additional networks that are not configured (saved).

+ AddService("stub_wifi3", "wifi3", shill::kTypeWifi, shill::kStateIdle);

+ AddService("stub_wifi4", "wifi4", shill::kTypeWifi, shill::kStateIdle);

+ EXPECT_TRUE(RunNetworkingSubtest("getNetworks")) << message_;

IN_PROC_BROWSER_TEST_P(ExtensionNetworkingPrivateApiTest, GetVisibleNetworks) {

EXPECT_TRUE(RunNetworkingSubtest("getVisibleNetworks")) << message_;

}