Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1537)

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

Issue 280023003: Implement networkingPrivate.getNetworks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Feedback Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
diff --git a/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc b/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
index 499d172264484a63c23a27477a84ab0f44c5b246..76a2434981fc3c89b646f7b0ef58eae43154cdf4 100644
--- a/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
+++ b/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
@@ -138,7 +138,8 @@ class ExtensionNetworkingPrivateApiTest
ExtensionNetworkingPrivateApiTest()
#if defined(OS_CHROMEOS)
: detector_(NULL),
- service_test_(NULL)
+ service_test_(NULL),
+ manager_test_(NULL)
#endif
{
}
@@ -221,8 +222,9 @@ class ExtensionNetworkingPrivateApiTest
InitializeSanitizedUsername();
DBusThreadManager* dbus_manager = DBusThreadManager::Get();
- ShillManagerClient::TestInterface* manager_test =
- dbus_manager->GetShillManagerClient()->GetTestInterface();
+ manager_test_ = dbus_manager->GetShillManagerClient()->GetTestInterface();
+ service_test_ = dbus_manager->GetShillServiceClient()->GetTestInterface();
+
ShillIPConfigClient::TestInterface* ip_config_test =
dbus_manager->GetShillIPConfigClient()->GetTestInterface();
ShillDeviceClient::TestInterface* device_test =
@@ -230,8 +232,6 @@ class ExtensionNetworkingPrivateApiTest
ShillProfileClient::TestInterface* profile_test =
dbus_manager->GetShillProfileClient()->GetTestInterface();
- service_test_ = dbus_manager->GetShillServiceClient()->GetTestInterface();
-
device_test->ClearDevices();
service_test_->ClearServices();
@@ -323,7 +323,7 @@ class ExtensionNetworkingPrivateApiTest
AddService("stub_vpn1", "vpn1", shill::kTypeVPN, shill::kStateOnline);
- manager_test->SortManagerServices();
+ manager_test_->SortManagerServices();
content::RunAllPendingInMessageLoop();
}
@@ -358,6 +358,7 @@ class ExtensionNetworkingPrivateApiTest
NetworkPortalDetectorTestImpl* detector_;
ShillServiceClient::TestInterface* service_test_;
+ ShillManagerClient::TestInterface* manager_test_;
policy::MockConfigurationPolicyProvider provider_;
std::string userhash_;
#endif
@@ -392,7 +393,16 @@ IN_PROC_BROWSER_TEST_P(ExtensionNetworkingPrivateApiTest,
}
#if defined(OS_CHROMEOS)
-// Non-Chrome OS only supports wifi currently.
+// TODO(stevenjb/mef): Fix these on non-Chrome OS, crbug.com/371442.
+IN_PROC_BROWSER_TEST_P(ExtensionNetworkingPrivateApiTest, GetNetworks) {
+ // Remove "stub_wifi2" from the visible list.
+ manager_test_->RemoveManagerService("stub_wifi2", false);
+ // Add a couple of additional networks that are not configured (saved).
+ AddService("stub_wifi3", "wifi3", shill::kTypeWifi, shill::kStateIdle);
+ AddService("stub_wifi4", "wifi4", shill::kTypeWifi, shill::kStateIdle);
+ EXPECT_TRUE(RunNetworkingSubtest("getNetworks")) << message_;
+}
+
IN_PROC_BROWSER_TEST_P(ExtensionNetworkingPrivateApiTest, GetVisibleNetworks) {
EXPECT_TRUE(RunNetworkingSubtest("getVisibleNetworks")) << message_;
}

Powered by Google App Engine
This is Rietveld 408576698