Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp

Issue 2800213002: Avoid duplicate functions/code in core/inspector.
Patch Set: A third way Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp
diff --git a/third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp b/third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp
index f2cb7b982db5aa102552110daf00a9539febe857..d2390354dbf79ddb99f3855c92629a2473a6682c 100644
--- a/third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp
+++ b/third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp
@@ -58,6 +58,11 @@ String IdentifiersFactory::FrameId(LocalFrame* frame) {
}
// static
+String IdentifiersFactory::FrameIdSafe(LocalFrame* frame) {
+ return frame ? FrameId(frame) : "";
pfeldman 2017/07/21 18:10:59 Bake it into FrameId(), return String() if nullptr
Daniel Bratell 2017/07/23 20:14:12 Done.
+}
+
+// static
LocalFrame* IdentifiersFactory::FrameById(InspectedFrames* inspected_frames,
const String& frame_id) {
bool ok;

Powered by Google App Engine
This is Rietveld 408576698