Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: third_party/WebKit/Source/core/inspector/BUILD.gn

Issue 2800213002: Avoid duplicate functions/code in core/inspector.
Patch Set: A third way Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/BUILD.gn
diff --git a/third_party/WebKit/Source/core/inspector/BUILD.gn b/third_party/WebKit/Source/core/inspector/BUILD.gn
index d824be267aa4aaa1cb61055413b1bea5e558c924..4be89099a5c856bcefb0d959c1b922396f64ba49 100644
--- a/third_party/WebKit/Source/core/inspector/BUILD.gn
+++ b/third_party/WebKit/Source/core/inspector/BUILD.gn
@@ -11,8 +11,6 @@ _inspector_protocol_dir = "//third_party/inspector_protocol"
blink_core_sources("inspector") {
sources = [
- "AddStringToDigestor.cpp",
- "AddStringToDigestor.h",
"ConsoleMessage.cpp",
"ConsoleMessage.h",
"ConsoleMessageStorage.cpp",
@@ -46,6 +44,8 @@ blink_core_sources("inspector") {
"InspectorEmulationAgent.cpp",
"InspectorEmulationAgent.h",
"InspectorFrontendClient.h",
+ "InspectorHelpers.cpp",
+ "InspectorHelpers.h",
"InspectorHighlight.cpp",
"InspectorHighlight.h",
"InspectorHistory.cpp",
@@ -96,15 +96,6 @@ blink_core_sources("inspector") {
"WorkerThreadDebugger.h",
]
- jumbo_excluded_sources = [
- # Collides with InspectorPageAgent.cpp and
- # NetworkResourcesData.cpp (patch incoming)
- "InspectorNetworkAgent.cpp",
-
- # Collides with InspectorPageAgent.cpp (patch incoming)
- "MainThreadDebugger.cpp",
- ]
-
configs += [
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
"//build/config/compiler:no_size_t_to_int_warning",

Powered by Google App Engine
This is Rietveld 408576698