third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp - Issue 2800213002: Avoid duplicate functions/code in core/inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp

Issue 2800213002: Avoid duplicate functions/code in core/inspector.

Patch Set: Merge two UrlWithoutFragment() and two FrameId() functions. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp

diff --git a/third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp b/third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp

index f2cb7b982db5aa102552110daf00a9539febe857..d2390354dbf79ddb99f3855c92629a2473a6682c 100644

--- a/third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp

+++ b/third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp

@@ -58,6 +58,11 @@ String IdentifiersFactory::FrameId(LocalFrame* frame) {

}

// static

+String IdentifiersFactory::FrameIdSafe(LocalFrame* frame) {

+ return frame ? FrameId(frame) : "";

+// static

LocalFrame* IdentifiersFactory::FrameById(InspectedFrames* inspected_frames,

const String& frame_id) {

bool ok;