Avoid duplicate functions/code in core/inspector.

third_party/WebKit/Source/core/inspector/InspectorHelpers.cpp

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "core/inspector/AddStringToDigestor.h"
+#include "core/inspector/InspectorHelpers.h"
 
+#include "core/inspector/IdentifiersFactory.h"
 #include "platform/wtf/text/WTFString.h"
 #include "public/platform/WebCrypto.h"
 
 namespace blink {
 
 void AddStringToDigestor(WebCryptoDigestor* digestor, const String& string) {
   const CString c_string = string.Utf8();

[pfeldman, 2017/07/21 18:10:59]

Could you just inline this?

[Daniel Bratell, 2017/07/23 20:14:12]

If "string.Utf8()" is moved to be inside the function calls the conversion to
UTF-8 will be executed twice. Once to pass a pointer, once to calculate the
length of UTF-8 string.

Or did you intend to comment on the whole function and wanted it to move to the
header? That would be against the style guide (
https://www.chromium.org/developers/coding-style/cpp-dos-and-donts ).

[pfeldman, 2017/07/25 00:14:43]

I wanted to inline these two lines into both call sites.

   digestor->Consume(reinterpret_cast<const unsigned char*>(c_string.data()),
                     c_string.length());
 }
 
+KURL UrlWithoutFragment(const KURL& url) {
+  KURL result = url;

[pfeldman, 2017/07/21 18:10:59]

ditto

[Daniel Bratell, 2017/07/23 20:14:12]

Inline result? There is a non-const destructive function called on it so it's
not just to move it but I changed the arguent to a url copy instead of a
reference. Saved one line.

Or do you mean inlining the whole method? (Your comment is on the local variable
but maybe that is just off by one). I think that would be against the style
guide as well.

[pfeldman, 2017/07/25 00:14:43]

Inline entire method:

KURL nofragment = url;
nofragment.RemoveFragmentIdentifier();

in both call sites.

+  result.RemoveFragmentIdentifier();
+  return result;
+}
+
 }  // namespace blink