Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h

Issue 2800213002: Avoid duplicate functions/code in core/inspector.
Patch Set: Merge two UrlWithoutFragment() and two FrameId() functions. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 17 matching lines...) Expand all
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef InspectorBaseAgent_h 31 #ifndef InspectorBaseAgent_h
32 #define InspectorBaseAgent_h 32 #define InspectorBaseAgent_h
33 33
34 #include "core/CoreExport.h" 34 #include "core/CoreExport.h"
35 #include "core/CoreProbeSink.h" 35 #include "core/CoreProbeSink.h"
36 #include "core/inspector/protocol/Protocol.h" 36 #include "core/inspector/protocol/Protocol.h"
37 #include "platform/heap/Handle.h" 37 #include "platform/heap/Handle.h"
38 #include "platform/weborigin/KURL.h"
38 #include "platform/wtf/Forward.h" 39 #include "platform/wtf/Forward.h"
39 #include "platform/wtf/text/WTFString.h" 40 #include "platform/wtf/text/WTFString.h"
40 41
41 namespace blink { 42 namespace blink {
42 43
43 class LocalFrame; 44 class LocalFrame;
44 45
45 class CORE_EXPORT InspectorAgent 46 class CORE_EXPORT InspectorAgent
46 : public GarbageCollectedFinalized<InspectorAgent> { 47 : public GarbageCollectedFinalized<InspectorAgent> {
47 public: 48 public:
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 typename DomainMetainfo::FrontendClass* GetFrontend() const { 103 typename DomainMetainfo::FrontendClass* GetFrontend() const {
103 return frontend_.get(); 104 return frontend_.get();
104 } 105 }
105 Member<CoreProbeSink> instrumenting_agents_; 106 Member<CoreProbeSink> instrumenting_agents_;
106 protocol::DictionaryValue* state_; 107 protocol::DictionaryValue* state_;
107 108
108 private: 109 private:
109 std::unique_ptr<typename DomainMetainfo::FrontendClass> frontend_; 110 std::unique_ptr<typename DomainMetainfo::FrontendClass> frontend_;
110 }; 111 };
111 112
113 KURL UrlWithoutFragment(const KURL&);
pfeldman 2017/07/05 18:24:54 This really is not a great place for this method.
114
112 } // namespace blink 115 } // namespace blink
113 116
114 #endif // !defined(InspectorBaseAgent_h) 117 #endif // !defined(InspectorBaseAgent_h)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698