Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

Issue 2800133003: Avoid duplicate functions: one AddStringToDigestor is enough (Closed)
Patch Set: New idea. Include the string type in the name. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
index 8d2ea535cf47fb4890d1784a3931bfaa62ea71f4..6bcc31329a21ff2815c25a76c8f73440da31867e 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
@@ -454,8 +454,8 @@ static CSSPropertyID g_transition_properties[] = {
CSSPropertyTransitionProperty, CSSPropertyTransitionTimingFunction,
};
-static void AddStringToDigestor(WebCryptoDigestor* digestor,
- const String& string) {
+static void AddAsciiStringToDigestor(WebCryptoDigestor* digestor,
+ const String& string) {
digestor->Consume(
reinterpret_cast<const unsigned char*>(string.Ascii().data()),
string.length());
alph 2017/07/10 21:26:06 ditto.
@@ -482,8 +482,8 @@ String InspectorAnimationAgent::CreateCSSId(blink::Animation& animation) {
css_agent_->MatchingStyles(element);
std::unique_ptr<WebCryptoDigestor> digestor =
CreateDigestor(kHashAlgorithmSha1);
- AddStringToDigestor(digestor.get(), type);
- AddStringToDigestor(digestor.get(), animation.id());
+ AddAsciiStringToDigestor(digestor.get(), type);
+ AddAsciiStringToDigestor(digestor.get(), animation.id());
for (CSSPropertyID property : css_properties) {
CSSStyleDeclaration* style =
css_agent_->FindEffectiveDeclaration(property, styles);
@@ -491,11 +491,11 @@ String InspectorAnimationAgent::CreateCSSId(blink::Animation& animation) {
if (!style || !style->ParentStyleSheet() || !style->parentRule() ||
style->parentRule()->type() != CSSRule::kStyleRule)
continue;
- AddStringToDigestor(digestor.get(), getPropertyNameString(property));
- AddStringToDigestor(digestor.get(),
- css_agent_->StyleSheetId(style->ParentStyleSheet()));
- AddStringToDigestor(digestor.get(),
- ToCSSStyleRule(style->parentRule())->selectorText());
+ AddAsciiStringToDigestor(digestor.get(), getPropertyNameString(property));
+ AddAsciiStringToDigestor(
+ digestor.get(), css_agent_->StyleSheetId(style->ParentStyleSheet()));
+ AddAsciiStringToDigestor(
+ digestor.get(), ToCSSStyleRule(style->parentRule())->selectorText());
}
DigestValue digest_result;
FinishDigestor(digestor.get(), digest_result);

Powered by Google App Engine
This is Rietveld 408576698