Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 280013003: More implementation details of extension content verification (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ready for review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index fd12b351d1e52fe69baabce4ab9c84d1c3b4272b..f3f975d6057d61d600427a44bfb2d3c6ee77e40d 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -78,6 +78,7 @@
using content::BrowserContext;
using content::BrowserThread;
using content::DevToolsAgentHost;
+using extensions::ContentVerifierKey;
using extensions::CrxInstaller;
using extensions::Extension;
using extensions::ExtensionIdSet;
@@ -88,6 +89,7 @@ using extensions::FeatureSwitch;
using extensions::InstallVerifier;
using extensions::ManagementPolicy;
using extensions::Manifest;
+using extensions::ManifestURL;
using extensions::PermissionMessage;
using extensions::PermissionMessages;
using extensions::PermissionSet;
@@ -2395,7 +2397,26 @@ void ExtensionService::UpdateGreylistedExtensions(
}
}
-void ExtensionService::ContentVerifyFailed(const std::string& extension_id) {
+bool ExtensionService::ShouldBeVerified(const Extension& extension) {
+ return ((extension.is_extension() || extension.is_legacy_packaged_app()) &&
+ ManifestURL::UpdatesFromGallery(&extension) &&
+ Manifest::IsAutoUpdateableLocation(extension.location()));
+ return false;
+}
+
+const ContentVerifierKey& ExtensionService::PublicKey() {
+ static ContentVerifierKey key(
+ extension_misc::kWebstoreSignaturesPublicKey,
+ extension_misc::kWebstoreSignaturesPublicKeySize);
+ return key;
+}
+
+GURL ExtensionService::GetSignatureFetchUrl(const std::string& extension_id,
+ const base::Version& version) {
+ return GURL();
+}
+
+void ExtensionService::VerifyFailed(const std::string& extension_id) {
DisableExtension(extension_id, Extension::DISABLE_CORRUPTED);
}

Powered by Google App Engine
This is Rietveld 408576698