More implementation details of extension content verification

chrome/browser/extensions/extension_system_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_system_impl.h"
 
 #include "base/base_switches.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ skipping 121 matching lines @@
     management_policy_->RegisterProvider(
         device_local_account_management_policy_provider_.get());
   }
 #endif  // defined (OS_CHROMEOS)
 
   management_policy_->RegisterProvider(install_verifier_.get());
 
 #endif  // defined(ENABLE_EXTENSIONS)
 }
 
-static bool ShouldVerifyExtensionContent(const Extension* extension) {
-  return ((extension->is_extension() || extension->is_legacy_packaged_app()) &&
-          ManifestURL::UpdatesFromGallery(extension) &&
-          Manifest::IsAutoUpdateableLocation(extension->location()));
-}
-
 void ExtensionSystemImpl::Shared::Init(bool extensions_enabled) {
   const CommandLine* command_line = CommandLine::ForCurrentProcess();
 
   navigation_observer_.reset(new NavigationObserver(profile_));
 
   bool allow_noisy_errors = !command_line->HasSwitch(switches::kNoErrorDialogs);
   ExtensionErrorReporter::Init(allow_noisy_errors);
 
   user_script_master_ = new UserScriptMaster(profile_);
 
@@ skipping 14 matching lines @@
       autoupdate_enabled,
       extensions_enabled,
       &ready_));
 
   // These services must be registered before the ExtensionService tries to
   // load any extensions.
   {
     install_verifier_.reset(
         new InstallVerifier(ExtensionPrefs::Get(profile_), profile_));
     install_verifier_->Init();
-    ContentVerifierFilter filter = base::Bind(&ShouldVerifyExtensionContent);
-    content_verifier_ = new ContentVerifier(profile_, filter);
-    content_verifier_->AddObserver(extension_service_.get());
+    content_verifier_ = new ContentVerifier(profile_, extension_service_.get());
     content_verifier_->Start();
     info_map()->SetContentVerifier(content_verifier_.get());
 
     management_policy_.reset(new ManagementPolicy);
     RegisterManagementPolicyProviders();
   }
 
   bool skip_session_extensions = false;
 #if defined(OS_CHROMEOS)
   // Skip loading session extensions if we are not in a user session.
@@ skipping 55 matching lines @@
     }
   }
 }
 
 void ExtensionSystemImpl::Shared::Shutdown() {
   if (extension_warning_service_) {
     extension_warning_service_->RemoveObserver(
         extension_warning_badge_service_.get());
   }
   if (content_verifier_) {
-    if (extension_service_)
-      content_verifier_->RemoveObserver(extension_service_.get());
     content_verifier_->Shutdown();
   }
 
   if (extension_service_)
     extension_service_->Shutdown();
 }
 
 StateStore* ExtensionSystemImpl::Shared::state_store() {
   return state_store_.get();
 }
@@ skipping 189 matching lines @@
 void ExtensionSystemImpl::UnregisterExtensionWithRequestContexts(
     const std::string& extension_id,
     const UnloadedExtensionInfo::Reason reason) {
   BrowserThread::PostTask(
       BrowserThread::IO,
       FROM_HERE,
       base::Bind(&InfoMap::RemoveExtension, info_map(), extension_id, reason));
 }
 
 }  // namespace extensions