Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart

Issue 2800083002: Complain about incorrect this/super constructor initializers. (Closed)
Patch Set: Address comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
index 45b17e597b90736e39df436e4336873dd2b672b3..0f87d31356e66e4ac1ccda31dc00a67c355f1161 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
@@ -44,6 +44,7 @@ import 'kernel_builder.dart'
KernelProcedureBuilder,
KernelTypeBuilder,
KernelTypeVariableBuilder,
+ LibraryBuilder,
MemberBuilder,
MetadataBuilder,
NamedMixinApplicationBuilder,
@@ -340,9 +341,10 @@ class KernelLibraryBuilder
return builder;
}
- void buildBuilder(Builder builder) {
+ @override
+ void buildBuilder(Builder builder, LibraryBuilder coreLibrary) {
if (builder is SourceClassBuilder) {
- Class cls = builder.build(this);
+ Class cls = builder.build(this, coreLibrary);
library.addClass(cls);
} else if (builder is KernelFieldBuilder) {
library.addMember(builder.build(this)..isStatic = true);
@@ -352,7 +354,7 @@ class KernelLibraryBuilder
// Kernel discard typedefs and use their corresponding function types
// directly.
} else if (builder is KernelEnumBuilder) {
- library.addClass(builder.build(this));
+ library.addClass(builder.build(this, coreLibrary));
} else if (builder is PrefixBuilder) {
// Ignored. Kernel doesn't represent prefixes.
} else if (builder is BuiltinTypeBuilder) {
@@ -362,8 +364,9 @@ class KernelLibraryBuilder
}
}
- Library build() {
- super.build();
+ @override
+ Library build(LibraryBuilder coreLibrary) {
+ super.build(coreLibrary);
library.name = name;
library.procedures.sort(compareProcedures);
return library;

Powered by Google App Engine
This is Rietveld 408576698