Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: pkg/front_end/lib/src/fasta/dill/dill_member_builder.dart

Issue 2800083002: Complain about incorrect this/super constructor initializers. (Closed)
Patch Set: Address comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/dill/dill_member_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/dill/dill_member_builder.dart b/pkg/front_end/lib/src/fasta/dill/dill_member_builder.dart
index a83da33941de3d6b32f81e38d56682d320a47f1c..1c666068d4390c8518a6d03acf7f27af99a819a3 100644
--- a/pkg/front_end/lib/src/fasta/dill/dill_member_builder.dart
+++ b/pkg/front_end/lib/src/fasta/dill/dill_member_builder.dart
@@ -9,7 +9,11 @@ import 'package:kernel/ast.dart'
import '../errors.dart' show internalError;
-import '../kernel/kernel_builder.dart' show Builder, MemberBuilder;
+import '../kernel/kernel_builder.dart'
+ show
+ Builder,
+ MemberBuilder,
+ isRedirectingGenerativeConstructorImplementation;
import '../modifier.dart'
show abstractMask, constMask, externalMask, finalMask, staticMask;
@@ -44,6 +48,11 @@ class DillMemberBuilder extends MemberBuilder {
bool get isOperator => identical(ProcedureKind.Operator, kind);
bool get isFactory => identical(ProcedureKind.Factory, kind);
+
+ bool get isRedirectingGenerativeConstructor {
+ return isConstructor &&
+ isRedirectingGenerativeConstructorImplementation(member);
+ }
}
int computeModifiers(Member member) {
« no previous file with comments | « pkg/front_end/lib/src/fasta/builder/member_builder.dart ('k') | pkg/front_end/lib/src/fasta/kernel/body_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698