Complain about incorrect this/super constructor initializers.

pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.kernel_enum_builder;
 
 import 'package:kernel/ast.dart'
     show
         Arguments,
         AsyncMarker,
         Class,
         Constructor,
         ConstructorInvocation,
         DirectPropertyGet,
         Expression,
         Field,
         FieldInitializer,
         IntLiteral,
         InterfaceType,
         ListLiteral,
         MapEntry,
         MapLiteral,
         MethodInvocation,
         ProcedureKind,
         ReturnStatement,
         StaticGet,
         StringLiteral,
+        SuperInitializer,
         ThisExpression,
         VariableGet;
 
 import '../errors.dart' show inputError;
 
 import '../modifier.dart' show constMask, finalMask, staticMask;
 
 import '../names.dart' show indexGetName;
 
 import '../source/source_class_builder.dart' show SourceClassBuilder;
 
 import 'kernel_builder.dart'
     show
         Builder,
         EnumBuilder,
         FormalParameterBuilder,
+        KernelClassBuilder,
         KernelConstructorBuilder,
         KernelFieldBuilder,
         KernelFormalParameterBuilder,
         KernelLibraryBuilder,
         KernelNamedTypeBuilder,
         KernelProcedureBuilder,
         KernelTypeBuilder,
         LibraryBuilder,
         MemberBuilder,
         MetadataBuilder,
         Scope;
 
 class KernelEnumBuilder extends SourceClassBuilder
     implements EnumBuilder<KernelTypeBuilder, InterfaceType> {
   final List<Object> constantNamesAndOffsets;
 
   final MapLiteral toStringMap;
 
-  final KernelTypeBuilder intType;
+  final KernelNamedTypeBuilder intType;
 
-  final KernelTypeBuilder stringType;
+  final KernelNamedTypeBuilder stringType;
+
+  final KernelNamedTypeBuilder objectType;
+
+  final KernelNamedTypeBuilder listType;
 
   KernelEnumBuilder.internal(
       List<MetadataBuilder> metadata,
       String name,
       Scope scope,
       Scope constructors,
       Class cls,
       this.constantNamesAndOffsets,
       this.toStringMap,
       this.intType,
+      this.listType,
+      this.objectType,
       this.stringType,
       LibraryBuilder parent,
       int charOffset)
       : super(metadata, 0, name, null, null, null, scope, constructors, parent,
             null, charOffset, cls);
 
   factory KernelEnumBuilder(
       List<MetadataBuilder> metadata,
       String name,
       List<Object> constantNamesAndOffsets,
       KernelLibraryBuilder parent,
       int charOffset,
       int charEndOffset) {
     constantNamesAndOffsets ??= const <Object>[];
     // TODO(ahe): These types shouldn't be looked up in scope, they come
     // directly from dart:core.
-    KernelTypeBuilder intType = parent.addType(
-        new KernelNamedTypeBuilder("int", null, charOffset, parent.fileUri));
-    KernelTypeBuilder stringType = parent.addType(
-        new KernelNamedTypeBuilder("String", null, charOffset, parent.fileUri));
+    KernelTypeBuilder intType =
+        new KernelNamedTypeBuilder("int", null, charOffset, parent.fileUri);
+    KernelTypeBuilder stringType =
+        new KernelNamedTypeBuilder("String", null, charOffset, parent.fileUri);
+    KernelNamedTypeBuilder objectType =
+        new KernelNamedTypeBuilder("Object", null, charOffset, parent.fileUri);
     Class cls = new Class(name: name);
     Map<String, MemberBuilder> members = <String, MemberBuilder>{};
     Map<String, MemberBuilder> constructors = <String, MemberBuilder>{};
     KernelNamedTypeBuilder selfType =
         new KernelNamedTypeBuilder(name, null, charOffset, parent.fileUri);
-    KernelTypeBuilder listType = parent.addType(new KernelNamedTypeBuilder(
-        "List", <KernelTypeBuilder>[selfType], charOffset, parent.fileUri));
+    KernelTypeBuilder listType = new KernelNamedTypeBuilder(
+        "List", <KernelTypeBuilder>[selfType], charOffset, parent.fileUri);
 
     /// From Dart Programming Language Specification 4th Edition/December 2015:
     ///     metadata class E {
     ///       final int index;
     ///       const E(this.index);
     ///       static const E id0 = const E(0);
     ///       ...
     ///       static const E idn-1 = const E(n - 1);
     ///       static const List<E> values = const <E>[id0, ..., idn-1];
     ///       String toString() => { 0: ‘E.id0’, . . ., n-1: ‘E.idn-1’}[index]
@@ skipping 52 matching lines @@
     MapLiteral toStringMap = new MapLiteral(toStringEntries, isConst: true);
     KernelEnumBuilder enumBuilder = new KernelEnumBuilder.internal(
         metadata,
         name,
         new Scope(members, null, parent.scope, isModifiable: false),
         new Scope(constructors, null, null, isModifiable: false),
         cls,
         constantNamesAndOffsets,
         toStringMap,
         intType,
+        listType,
+        objectType,
         stringType,
         parent,
         charOffset);
     // TODO(sigmund): dynamic should be `covariant MemberBuilder`.
     void setParent(String name, dynamic b) {
       MemberBuilder builder = b;
       builder.parent = enumBuilder;
     }
 
     members.forEach(setParent);
     constructors.forEach(setParent);
-    selfType.builder = enumBuilder;
+    selfType.bind(enumBuilder);
     return enumBuilder;
   }
 
   KernelTypeBuilder get mixedInType => null;
 
   InterfaceType buildType(
       LibraryBuilder library, List<KernelTypeBuilder> arguments) {
     return cls.rawType;
   }
 
-  Class build(KernelLibraryBuilder libraryBuilder) {
+  @override
+  Class build(KernelLibraryBuilder libraryBuilder, LibraryBuilder coreLibrary) {
     if (constantNamesAndOffsets.isEmpty) {
       libraryBuilder.addCompileTimeError(
           -1, "An enum declaration can't be empty.");
     }
+    intType.resolveIn(coreLibrary.scope);
+    stringType.resolveIn(coreLibrary.scope);
+    objectType.resolveIn(coreLibrary.scope);
+    listType.resolveIn(coreLibrary.scope);
     toStringMap.keyType = intType.build(libraryBuilder);
     toStringMap.valueType = stringType.build(libraryBuilder);
     KernelFieldBuilder indexFieldBuilder = this["index"];
     Field indexField = indexFieldBuilder.build(libraryBuilder);
     KernelProcedureBuilder toStringBuilder = this["toString"];
     toStringBuilder.body = new ReturnStatement(new MethodInvocation(
         toStringMap,
         indexGetName,
         new Arguments(<Expression>[
           new DirectPropertyGet(new ThisExpression(), indexField)
         ])));
     List<Expression> values = <Expression>[];
     for (int i = 0; i < constantNamesAndOffsets.length; i += 2) {
       String name = constantNamesAndOffsets[i];
       KernelFieldBuilder builder = this[name];
       values.add(new StaticGet(builder.build(libraryBuilder)));
     }
     KernelFieldBuilder valuesBuilder = this["values"];
     valuesBuilder.build(libraryBuilder);
     valuesBuilder.initializer =
         new ListLiteral(values, typeArgument: cls.rawType, isConst: true);
     KernelConstructorBuilder constructorBuilder = constructorScopeBuilder[""];
     Constructor constructor = constructorBuilder.build(libraryBuilder);
     constructor.initializers.insert(
         0,
         new FieldInitializer(indexField,
             new VariableGet(constructor.function.positionalParameters.single))
           ..parent = constructor);
+    KernelClassBuilder objectClass = objectType.builder;
+    MemberBuilder superConstructor =
+        objectClass.findConstructorOrFactory("", charOffset, fileUri);
+    if (superConstructor == null || !superConstructor.isConstructor) {
+      addCompileTimeError(
+          -1, "'Object' has no constructor that takes no arguments.");

[Paul Berry, 2017/04/07 15:56:38]

Similar issue here to the one above.

[ahe, 2017/04/07 18:19:18]

Will do.

+    } else {
+      constructor.initializers.add(
+          new SuperInitializer(superConstructor.target, new Arguments.empty())
+            ..parent = constructor);
+    }
     int index = 0;
     for (int i = 0; i < constantNamesAndOffsets.length; i += 2) {
       String constant = constantNamesAndOffsets[i];
       KernelFieldBuilder field = this[constant];
       field.build(libraryBuilder);
       Arguments arguments =
           new Arguments(<Expression>[new IntLiteral(index++)]);
       field.initializer =
           new ConstructorInvocation(constructor, arguments, isConst: true);
     }
-    return super.build(libraryBuilder);
+    return super.build(libraryBuilder, coreLibrary);
   }
 
   @override
   Builder findConstructorOrFactory(String name, int charOffset, Uri uri) {
     return null;
   }
 }