Force a python_only rjsmin version in devtools build

Force a python_only rjsmin version in devtools build

Avoid accidentally picking up a system native _rjsmin module which can
be an incompatible version that will silently corrupt the generated
devtools JS files. As we do not bundle a native _rjsmin module, use
python_only=True to avoid "import _rjsmin".

Or in other words, if the python version has been fixed to do something
extra the plain version doesn't (https://codereview.chromium.org/2229683002/
https://codereview.chromium.org/2553843002) then it better not try to
load an unpatched native module.

BUG=709025

[tsniatowski, 2017-04-07 07:13:38]

Description was changed from

==========
Force a python_only rjsmin version in devtools build

Avoid accidentally picking up a system native _rjsmin module which can
be an incompatible version that will silently corrupt the generated
devtools JS files. As we do not bundle a native _rjsmin module, use
python_only=True to avoid "import _rjsmin".

Or in other words, if the python version has been fixed to do something
extra the plain version doesn't (https://codereview.chromium.org/2229683002/
https://codereview.chromium.org/2553843002) then it better not try to
load an unpatched native module.

BUG=640973
==========

to

==========
Force a python_only rjsmin version in devtools build

Avoid accidentally picking up a system native _rjsmin module which can
be an incompatible version that will silently corrupt the generated
devtools JS files. As we do not bundle a native _rjsmin module, use
python_only=True to avoid "import _rjsmin".

Or in other words, if the python version has been fixed to do something
extra the plain version doesn't (https://codereview.chromium.org/2229683002/
https://codereview.chromium.org/2553843002) then it better not try to
load an unpatched native module.

BUG=640973
==========

[tsniatowski, 2017-04-07 07:13:38]

tsniatowski@opera.com changed reviewers:
+ lushnikov@chromium.org

[tsniatowski, 2017-04-07 07:13:58]

PTAL

[tsniatowski, 2017-04-07 07:17:29]

Description was changed from

==========
Force a python_only rjsmin version in devtools build

Avoid accidentally picking up a system native _rjsmin module which can
be an incompatible version that will silently corrupt the generated
devtools JS files. As we do not bundle a native _rjsmin module, use
python_only=True to avoid "import _rjsmin".

Or in other words, if the python version has been fixed to do something
extra the plain version doesn't (https://codereview.chromium.org/2229683002/
https://codereview.chromium.org/2553843002) then it better not try to
load an unpatched native module.

BUG=640973
==========

to

==========
Force a python_only rjsmin version in devtools build

Avoid accidentally picking up a system native _rjsmin module which can
be an incompatible version that will silently corrupt the generated
devtools JS files. As we do not bundle a native _rjsmin module, use
python_only=True to avoid "import _rjsmin".

Or in other words, if the python version has been fixed to do something
extra the plain version doesn't (https://codereview.chromium.org/2229683002/
https://codereview.chromium.org/2553843002) then it better not try to
load an unpatched native module.

BUG=709025
==========

[lushnikov, 2017-04-07 22:15:36]

lushnikov@chromium.org changed reviewers:
+ allada@chromium.org

[lushnikov, 2017-04-07 22:15:37]

Thank you for the patch! It's unclear why rjsmin has this "python_only" flag. 

AFAIR the changes we did to the rjsmin were upstreamed. @allada, is this the
case?

Can we come up with a solution here which we would be able to upstream?
Otherwise we'll be bound to maintain rjsmin script by ourselves.

[kailoran, 2017-04-08 12:32:55]

On 2017/04/07 22:15:37, lushnikov wrote:
> Thank you for the patch! It's unclear why rjsmin has this "python_only" flag. 
> 
> AFAIR the changes we did to the rjsmin were upstreamed. @allada, is this the
> case?
> 
> Can we come up with a solution here which we would be able to upstream?
> Otherwise we'll be bound to maintain rjsmin script by ourselves.

For the record, upstreaming by itself won't fix everything, someone may still
have an old version which could get picked up and secretly break things. I guess
ideally there should be some kind of version check in the python code that'll
avoid using an older (or maybe simply mismatched) native module. Probably not
worth the effort in a forked copy.

[allada, 2017-04-10 19:03:10]

On 2017/04/08 12:32:55, kailoran wrote:
> For the record, upstreaming by itself won't fix everything, someone may still
> have an old version which could get picked up and secretly break things. I
guess
> ideally there should be some kind of version check in the python code that'll
> avoid using an older (or maybe simply mismatched) native module. Probably not
> worth the effort in a forked copy.

I have submitted a request to the maintainer of rjsmin for consideration.
If/when
a solution is found we will pull rjsmin and do any rebinding needed.

See: https://github.com/ndparker/rjsmin/issues/11