Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 280003003: Add SetClient method implementation to InterfaceImpl. (Closed)

Created:
6 years, 7 months ago by darin (slow to review)
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, ben+mojo_chromium.org
Visibility:
Public.

Description

Add SetClient method implementation to InterfaceImpl. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269917

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -128 lines) Patch
M chrome/browser/ui/webui/omnibox/omnibox_ui_handler.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc View 1 3 chunks +2 lines, -7 lines 0 comments Download
M content/browser/mojo/mojo_application_host.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/mojo/mojo_application_host.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/examples/launcher/launcher.cc View 4 chunks +1 line, -6 lines 0 comments Download
M mojo/public/cpp/bindings/interface_impl.h View 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_impl_internal.h View 3 chunks +9 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_internal.h View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/no_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/handle_passing_unittest.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M mojo/public/cpp/bindings/tests/request_response_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/service_manager/service_manager.cc View 6 chunks +3 lines, -15 lines 0 comments Download
M mojo/service_manager/service_manager_unittest.cc View 2 chunks +1 line, -9 lines 0 comments Download
M mojo/services/gles2/command_buffer_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/gles2/command_buffer_impl.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_service.cc View 4 chunks +5 lines, -11 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.h View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.cc View 1 2 3 5 chunks +13 lines, -17 lines 0 comments Download
M mojo/shell/app_child_process.cc View 4 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
darin (slow to review)
This was a suggestion by Dave. Previously, ServiceConnection<..> had a client() method, so this is ...
6 years, 7 months ago (2014-05-09 22:57:02 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-12 15:03:46 UTC) #2
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 7 months ago (2014-05-12 16:05:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/280003003/1
6 years, 7 months ago (2014-05-12 16:05:57 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-12 17:17:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-12 17:20:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/67156) linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_dbg/builds/24195)
6 years, 7 months ago (2014-05-12 17:20:28 UTC) #7
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 7 months ago (2014-05-12 17:32:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/280003003/20001
6 years, 7 months ago (2014-05-12 17:33:21 UTC) #9
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 7 months ago (2014-05-12 17:53:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/280003003/40001
6 years, 7 months ago (2014-05-12 17:53:40 UTC) #11
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 7 months ago (2014-05-12 20:32:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/280003003/60001
6 years, 7 months ago (2014-05-12 20:34:32 UTC) #13
darin (slow to review)
6 years, 7 months ago (2014-05-12 23:48:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 manually as r269917 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698