Chromium Code Reviews
Help | Chromium Project | Sign in
(108)

Issue 2800019: [Mac] Give the Wrench menu keyboard shortcuts. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by Robert Sesek
Modified:
4 years ago
Reviewers:
pink
CC:
chromium-reviews
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

[Mac] Give the Wrench menu keyboard shortcuts. Note that these key equivalents are for display only and do not get fired. Commands are routed through the main menu/CommandUpdater. BUG=45098 TEST=Open Wrench menu, see keyboard shortcuts. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50452

Patch Set 1 #

Total comments: 5

Patch Set 2 : Split out keymap into new file #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -3 lines) Patch
M app/app_base.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A app/menus/accelerator_cocoa.h View 1 1 chunk +58 lines, -0 lines 2 comments Download
A chrome/browser/cocoa/accelerators_cocoa.h View 1 chunk +38 lines, -0 lines 1 comment Download
A chrome/browser/cocoa/accelerators_cocoa.mm View 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/accelerators_cocoa_unittest.mm View 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/menu_controller.mm View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/toolbar_controller.mm View 1 2 chunks +19 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
Robert Sesek
It'd be cool if this mapping of command_ids to key equivalents were globalized in code ...
4 years, 11 months ago (2010-06-21 15:23:57 UTC) #1
pink
http://codereview.chromium.org/2800019/diff/1/3 File app/menus/accelerator_cocoa.h (right): http://codereview.chromium.org/2800019/diff/1/3#newcode22 app/menus/accelerator_cocoa.h:22: : characters_([key_code copy]) { as of 15 minutes ago, ...
4 years, 11 months ago (2010-06-21 15:47:17 UTC) #2
Robert Sesek
All comments addressed.
4 years, 11 months ago (2010-06-21 18:45:43 UTC) #3
pink
4 years, 11 months ago (2010-06-21 19:21:56 UTC) #4
LGTM with minor nits.

http://codereview.chromium.org/2800019/diff/6001/7002
File app/menus/accelerator_cocoa.h (right):

http://codereview.chromium.org/2800019/diff/6001/7002#newcode31
app/menus/accelerator_cocoa.h:31: AcceleratorCocoa() : Accelerator() {}
not sure this is necessary, but can't hurt.

http://codereview.chromium.org/2800019/diff/6001/7002#newcode42
app/menus/accelerator_cocoa.h:42: bool operator ==(const AcceleratorCocoa& rhs)
const {
no space after "operator"?

http://codereview.chromium.org/2800019/diff/6001/7003
File chrome/browser/cocoa/accelerators_cocoa.h (right):

http://codereview.chromium.org/2800019/diff/6001/7003#newcode35
chrome/browser/cocoa/accelerators_cocoa.h:35: AcceleratorCocoaMap accelerators_;
DISALLOW_COPY_AND_ASSIGN(AcceleratorsCocoa)?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be