Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2800013003: Remove some unnecessary stuff from AudioOutputDelegateImplUnitTest. (Closed)

Created:
3 years, 8 months ago by Max Morin
Modified:
3 years, 8 months ago
Reviewers:
Guido Urdaneta, o1ka
CC:
chromium-reviews, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some unnecessary stuff from AudioOutputDelegateImplUnitTest. Not sure why they are there to begin with. BUG=656923

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M content/browser/renderer_host/media/audio_output_delegate_impl_unittest.cc View 4 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Max Morin
Olga: PTAL. Is this all that's needed for now?
3 years, 8 months ago (2017-04-07 08:54:18 UTC) #2
o1ka
On 2017/04/07 08:54:18, Max Morin wrote: > Olga: PTAL. Is this all that's needed for ...
3 years, 8 months ago (2017-04-07 08:56:16 UTC) #3
Max Morin
Thanks! Dale: PTAL.
3 years, 8 months ago (2017-04-07 08:56:50 UTC) #6
Max Morin
Guido: As Dale is OOO, PTAL.
3 years, 8 months ago (2017-04-07 08:58:31 UTC) #8
Guido Urdaneta
lgtm
3 years, 8 months ago (2017-04-09 16:33:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800013003/1
3 years, 8 months ago (2017-04-10 06:06:52 UTC) #11
Max Morin
Thanks Guido.
3 years, 8 months ago (2017-04-10 06:22:15 UTC) #12
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 8 months ago (2017-04-10 06:37:01 UTC) #15
Max Morin
3 years, 8 months ago (2017-04-10 06:44:38 UTC) #16
On 2017/04/10 06:37:01, commit-bot: I haz the power wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the
> issue was successfully committed. Please check Git history manually and
re-check
> CQ or close this issue as needed.

Landed as
https://chromium.googlesource.com/chromium/src/+/c83cf384c45aa4b3aaacacc65c88...

Powered by Google App Engine
This is Rietveld 408576698