Check const constructors.

Check const constructors.

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/9356e3cd6109b3cc3e9ac4ea722e4ce5ad286993

[ahe, 2017-04-07 13:21:34]

ahe@google.com changed reviewers:
+ karlklose@google.com, paulberry@google.com

[ahe, 2017-04-07 13:21:34]

It looks like this change has little impact, but that's because a number of
negative tests already fails with a runtime error after CL 2800083002.

For example, tests/language/body_less_constructor_wrong_arg_negative_test.dart
now fails with a compile-time error as expected, not a runtime error.

In addition, I've noticed that our logic for checking exit codes is broken, and
I'm working on a fix for that.

[Paul Berry, 2017-04-07 15:59:20]

https://codereview.chromium.org/2799973003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2799973003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:582:
!receiver.isInitializer) {
It looks like isInitializer isn't defined on FastaAccessor.  Am I missing
something?

[ahe, 2017-04-07 18:11:15]

https://codereview.chromium.org/2799973003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2799973003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:582:
!receiver.isInitializer) {
On 2017/04/07 15:59:19, Paul Berry wrote:
> It looks like isInitializer isn't defined on FastaAccessor.  Am I missing
> something?

That part got included in CL 2800083002 by accident.

[Paul Berry, 2017-04-07 20:03:49]

lgtm

[ahe, 2017-04-20 08:56:05]

Description was changed from

==========
Check const constructors.
==========

to

==========
Check const constructors.

R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9356e3cd6109b3cc3e9ac4ea722e4ce5ad286993
==========

[ahe, 2017-04-20 08:56:06]

Committed patchset #1 (id:1) manually as
9356e3cd6109b3cc3e9ac4ea722e4ce5ad286993 (presubmit successful).