Treat loads of invalid URLs as no-ops unless triggered by window.open.

ios/web/web_state/ui/crw_web_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/web_state/ui/crw_web_controller.h"
 
 #import <WebKit/WebKit.h>
 
 #import <objc/runtime.h>
 #include <stddef.h>
@@ skipping 4286 matching lines @@
   _webProcessIsDead = NO;
   if (_isBeingDestroyed) {
     decisionHandler(WKNavigationActionPolicyCancel);
     return;
   }
 
   // The page will not be changed until this navigation is commited, so the
   // retrieved state will be pending until |didCommitNavigation| callback.
   [self updatePendingNavigationInfoFromNavigationAction:action];
 
-  // Invalid URLs should not be loaded.  However, simply doing nothing upon
-  // tapping a link or button is a jarring user experience.  Instead, cancel
-  // the invalid navigation and load about:blank if navigation was requested for
-  // the main frame.
+  // Invalid URLs should not be loaded.
   GURL requestURL = net::GURLWithNSURL(action.request.URL);
   if (!requestURL.is_valid()) {
     decisionHandler(WKNavigationActionPolicyCancel);
-    if (action.targetFrame.mainFrame) {
+    // The HTML5 spec indicates that window.open with an invalid URL should open
+    // about:blank.
+    BOOL isFirstLoadInOpenedWindow =
+        self.webState->HasOpener() &&
+        !self.webState->GetNavigationManager()->GetLastCommittedItem();
+    BOOL isMainFrame = action.targetFrame.mainFrame;
+    if (isFirstLoadInOpenedWindow && isMainFrame) {

[Eugene But (OOO till 7-30), 2017/04/06 18:34:19]

I thought this will break CRWWebControllerInvalidUrlTest.LoadInvalidURL, but it
does not. Do you know why?

[kkhorimoto, 2017/04/07 00:03:40]

It looks like WKWebView's |-loadHTMLString:baseURL:| rewrites invalid URLs to
about:blank before reaching this delegate callback.  I've created a bug and
added a TODO to revisit what we want to do with that test.  I'm not sure if we
depend on that behavior for that specific WKWebView API.

[Eugene But (OOO till 7-30), 2017/04/07 01:03:36]

Sorry looks like that test was useless :( I will delete it.

       GURL aboutBlankURL(url::kAboutBlankURL);
       web::NavigationManager::WebLoadParams loadParams(aboutBlankURL);
       loadParams.referrer = [self currentReferrer];
       self.webState->GetNavigationManager()->LoadURLWithParams(loadParams);
     }
     return;
   }
 
   BOOL allowLoad = [self shouldAllowLoadWithNavigationAction:action];
 
@@ skipping 744 matching lines @@
 - (void)simulateLoadRequestWithURL:(const GURL&)URL {
   _lastRegisteredRequestURL = URL;
   _loadPhase = web::LOAD_REQUESTED;
 }
 
 - (NSString*)referrerFromNavigationAction:(WKNavigationAction*)action {
   return [action.request valueForHTTPHeaderField:kReferrerHeaderName];
 }
 
 @end