Treat loads of invalid URLs as no-ops unless triggered by window.open.

ios/web/navigation/window_location_inttest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "base/mac/bind_objc_block.h"
 #include "base/mac/foundation_util.h"
 #include "base/memory/ptr_util.h"
 #import "base/strings/sys_string_conversions.h"
 #include "base/test/ios/wait_util.h"
 #import "ios/web/public/navigation_item.h"
@@ skipping 27 matching lines @@
 // Button IDs used in the window.location test page.
 const char kWindowLocationAssignID[] = "location-assign";
 const char kWindowLocationReplaceID[] = "location-replace";
 const char kWindowLocationReloadID[] = "location-reload";
 const char kWindowLocationSetToDOMStringID[] = "set-location-to-dom-string";
 
 // JavaScript functions on the window.location test page.
 NSString* const kUpdateURLScriptFormat = @"updateUrlToLoadText('%s')";
 NSString* const kGetURLScript = @"getUrl()";
 NSString* const kOnLoadCheckScript = @"isOnLoadTextVisible()";
+NSString* const kNoOpCheckScript = @"isNoOpTextVisible()";
 
 // URL of a sample file-based page.
 const char kSampleFileBasedURL[] =
     "http://ios/testing/data/http_server_files/chromium_logo_page.html";
 
 }  // namespace
 
 // Test fixture for window.location integration tests.
 class WindowLocationTest : public web::WebIntTest {
  protected:
@@ skipping 27 matching lines @@
   }
 
   // Executes JavaScript on the window.location test page and returns whether
   // |kOnLoadText| is visible.
   bool IsOnLoadTextVisible() {
     NSNumber* text_visible = base::mac::ObjCCastStrict<NSNumber>(
         ExecuteJavaScript(kOnLoadCheckScript));
     return [text_visible boolValue];
   }
 
+  // Executes JavaScript on the window.location test page and returns whether
+  // the no-op text is visible.  It is displayed 0.5 seconds after a button is
+  // tapped, and can be used to verify that a navigation did not occur.
+  bool IsNoOpTextVisible() {
+    NSNumber* text_visible = base::mac::ObjCCastStrict<NSNumber>(
+        ExecuteJavaScript(kNoOpCheckScript));
+    return [text_visible boolValue];
+  }
+
  private:
   GURL window_location_url_;
 };
 
 // Tests that calling window.location.assign() creates a new NavigationItem.
 TEST_F(WindowLocationTest, Assign) {
   // Navigate to about:blank so there is a forward entry to prune.
   GURL about_blank("about:blank");
   LoadUrl(about_blank);
   web::NavigationItem* about_blank_item =
@@ skipping 15 matching lines @@
 
   // Verify that |sample_url| was loaded and that |about_blank_item| was pruned.
   EXPECT_EQ(sample_url, navigation_manager()->GetLastCommittedItem()->GetURL());
   EXPECT_EQ(NSNotFound, GetIndexOfNavigationItem(about_blank_item));
 }
 
 // Tests that calling window.location.assign() with an unresolvable URL loads
 // about:blank.
 TEST_F(WindowLocationTest, WindowLocationAssignUnresolvable) {
   // Attempt to call window.location.assign() using an unresolvable URL.
-  GURL about_blank("about:blank");
   GURL unresolvable_url("http:https:not a url");
   SetWindowLocationUrl(unresolvable_url);
-  ExecuteBlockAndWaitForLoad(about_blank, ^{
-    ASSERT_TRUE(web::test::TapWebViewElementWithId(web_state(),
-                                                   kWindowLocationAssignID));
+  ASSERT_TRUE(
+      web::test::TapWebViewElementWithId(web_state(), kWindowLocationAssignID));
+
+  // Wait for the no-op text to appear.
+  base::test::ios::WaitUntilCondition(^bool {
+    return IsNoOpTextVisible();
   });
-
-  // Verify that about:blank was actually loaded.
-  EXPECT_EQ(about_blank,
-            navigation_manager()->GetLastCommittedItem()->GetURL());
 }
 
 // Tests that calling window.location.replace() doesn't create a new
 // NavigationItem.
 // TODO(crbug.com/307072): Enable test when location.replace is fixed.
 TEST_F(WindowLocationTest, DISABLED_Replace) {
   // Navigate to about:blank so there is a forward entry.
   GURL about_blank("about:blank");
   LoadUrl(about_blank);
   web::NavigationItem* about_blank_item =
@@ skipping 14 matching lines @@
   });
 
   // Verify that |sample_url| was loaded and that |about_blank_item| was pruned.
   web::NavigationItem* current_item =
       navigation_manager()->GetLastCommittedItem();
   EXPECT_EQ(sample_url, current_item->GetURL());
   EXPECT_EQ(GetIndexOfNavigationItem(current_item) + 1,
             GetIndexOfNavigationItem(about_blank_item));
 }
 
-// Tests that calling window.location.replace() with an unresolvable URL loads
-// about:blank.
+// Tests that calling window.location.replace() with an unresolvable URL is a
+// no-op.
 TEST_F(WindowLocationTest, WindowLocationReplaceUnresolvable) {
   // Attempt to call window.location.assign() using an unresolvable URL.
-  GURL about_blank("about:blank");
   GURL unresolvable_url("http:https:not a url");
   SetWindowLocationUrl(unresolvable_url);
-  ExecuteBlockAndWaitForLoad(about_blank, ^{
-    ASSERT_TRUE(web::test::TapWebViewElementWithId(web_state(),
-                                                   kWindowLocationReplaceID));
+  ASSERT_TRUE(web::test::TapWebViewElementWithId(web_state(),
+                                                 kWindowLocationReplaceID));
+
+  // Wait for the no-op text to appear.
+  base::test::ios::WaitUntilCondition(^bool {
+    return IsNoOpTextVisible();
   });
-
-  // Verify that about:blank was actually loaded.
-  EXPECT_EQ(about_blank,
-            navigation_manager()->GetLastCommittedItem()->GetURL());
 }
 
 // Tests that calling window.location.reload() causes an onload event to occur.
 TEST_F(WindowLocationTest, WindowLocationReload) {
   // Tap the window.location.reload() button.
   ExecuteBlockAndWaitForLoad(window_location_url(), ^{
     ASSERT_TRUE(web::test::TapWebViewElementWithId(web_state(),
                                                    kWindowLocationReloadID));
   });
 
@@ skipping 22 matching lines @@
   SetWindowLocationUrl(sample_url);
   ExecuteBlockAndWaitForLoad(sample_url, ^{
     ASSERT_TRUE(web::test::TapWebViewElementWithId(
         web_state(), kWindowLocationSetToDOMStringID));
   });
 
   // Verify that |sample_url| was loaded and that |about_blank_item| was pruned.
   EXPECT_EQ(sample_url, navigation_manager()->GetLastCommittedItem()->GetURL());
   EXPECT_EQ(NSNotFound, GetIndexOfNavigationItem(about_blank_item));
 }