Add gpu-rasterization test to Android gpu testbot.

Add gpu-rasterization test to Android gpu testbot.

BUG=368495
R=navabi@chromium.org, navabi@google.com, skyostil@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273386

[alokp, 2014-05-09 19:32:53]

Sami: Is there a way to test the patch locally or send a try job?

[Sami, 2014-05-16 10:18:59]

Sorry for the delay in getting to this. lgtm. Unfortunately I don't know of any
way to test this locally. Maybe Armand has a tip?

+navabi to approve

[navabi, 2014-05-20 20:47:17]

For local testing you can run the same command the gpu bot runs. E.g. take this
run:

http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%...

If you go to the stdio for slave steps, and search for bb_device_steps.py, you
will find a call that looks like this:

build/android/buildbot/bb_device_steps.py
'--factory-properties={"gclient_timeout": 3600, "gclient_env": {}, "clobber":
false, "GYP_DEFINES": " component=shared_library", "android_bot_id":
"gpu-builder-tests-dbg", "target_os": "android", "target": "Debug"}'
'--build-properties={"project": "", "workdir":
"/b/build/slave/Android_Debug__Nexus_7_", "got_nacl_revision": "13199",
"repository": "svn://svn-mirror.golo.chromium.org/chrome/trunk",
"got_webkit_revision": "174386", "buildername": "Android Debug (Nexus 7)",
"got_webrtc_revision": "6189", "got_revision": "271730",
"got_swarming_client_revision": "ae8085b09e6162b4ec869e430d7d09c16b32b433",
"scheduler": "gpu", "got_v8_revision": "21393", "mastername": "chromium.gpu",
"buildnumber": 8436, "slavename": "build37-a1", "blamelist_real":
["brettw@chromium.org", "bruening@google.com", "danakj@chromium.org",
"erg@chromium.org", "nkostylev@chromium.org", "piman@chromium.org",
"robertphillips@google.com", "scottmg@chromium.org", "vitalybuka@chromium.org"],
"blamelist":
"brettw@chromium.org,bruening@google.com,danakj@chromium.org,erg@chromium.org...,
"primary_repo": "", "branch": "src", "buildbotURL":
"http://build.chromium.org/p/chromium.gpu/", "revision": "271730"}' -f gpu

You can use the same call locally to test locally. You can also remove things
not necessary from that call like blamelist.

https://codereview.chromium.org/279993002/diff/1/build/android/buildbot/bb_de...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/279993002/diff/1/build/android/buildbot/bb_de...
build/android/buildbot/bb_device_steps.py:487: def RunGPUTests(options):
I think the PrintNamedStep should go here. Even with the current implementation,
the install happens as part of the previous step. See the following:

http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%...

http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%...

The install of ContentShell shows up as part of the provision_devices step.

[alokp, 2014-05-23 17:38:26]

https://codereview.chromium.org/279993002/diff/1/build/android/buildbot/bb_de...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/279993002/diff/1/build/android/buildbot/bb_de...
build/android/buildbot/bb_device_steps.py:487: def RunGPUTests(options):
OK. I added a gpu_tests step before the install, but left the other steps as it
is.

[alokp, 2014-05-23 17:45:52]

Looking at the Android-Debug (Nexus 7) testbot:
http://build.chromium.org/p/chromium.gpu/waterfall?builder=Android%20Debug%20...

I wonder is InstallApk step is at all necessary. provision_devices runs prior to
gpu_tests, which in fact installs the apk. In addition, since gpu_tests run with
android_content_shell browser, telemetry automatically refreshes the install. I
think we can remove the InstallApk step entirely. Am I misreading something?

[alokp, 2014-05-23 18:15:44]

After further digging, I think bb_device_steps.py should be executed like this:
build/android/buildbot/bb_device_steps.py --install ContentShell -f gpu

This will get rid of the need to install the apk for each test and make it
clearer. I am going to land this patch as is and then try to make the change on
the bots.

[alokp, 2014-05-23 18:16:29]

The CQ bit was checked by alokp@chromium.org

[commit-bot: I haz the power, 2014-05-23 18:17:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alokp@chromium.org/279993002/40001

[alokp, 2014-05-23 18:31:58]

navabi: OWNERS approval needed.

[commit-bot: I haz the power, 2014-05-23 20:27:52]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-23 20:33:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-23 20:33:25]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[alokp, 2014-05-28 21:23:07]

ping!

[navabi, 2014-05-28 21:54:04]

lgtm with nit

https://codereview.chromium.org/279993002/diff/40001/build/android/buildbot/b...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/279993002/diff/40001/build/android/buildbot/b...
build/android/buildbot/bb_device_steps.py:454:
bb_annotations.PrintNamedStep('pixel_tests')
Can we move the PrintNamedStep to the top of this function. Before the
InstallApk? I've seen this a lot and it gets confusing because the output from
the install part of this function will end up in whatever step happens to be
before the pixel_tests step.

[alokp, 2014-05-28 21:58:35]

https://codereview.chromium.org/279993002/diff/40001/build/android/buildbot/b...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/279993002/diff/40001/build/android/buildbot/b...
build/android/buildbot/bb_device_steps.py:454:
bb_annotations.PrintNamedStep('pixel_tests')
On 2014/05/28 21:54:04, navabi wrote:
> Can we move the PrintNamedStep to the top of this function. Before the
> InstallApk? I've seen this a lot and it gets confusing because the output from
> the install part of this function will end up in whatever step happens to be
> before the pixel_tests step.

Please review https://codereview.chromium.org/295983010/.
The install step is going away.

[Ken Russell (switch to Gerrit), 2014-05-28 22:03:04]

On 2014/05/28 21:58:35, Alok Priyadarshi wrote:
>
https://codereview.chromium.org/279993002/diff/40001/build/android/buildbot/b...
> File build/android/buildbot/bb_device_steps.py (right):
> 
>
https://codereview.chromium.org/279993002/diff/40001/build/android/buildbot/b...
> build/android/buildbot/bb_device_steps.py:454:
> bb_annotations.PrintNamedStep('pixel_tests')
> On 2014/05/28 21:54:04, navabi wrote:
> > Can we move the PrintNamedStep to the top of this function. Before the
> > InstallApk? I've seen this a lot and it gets confusing because the output
from
> > the install part of this function will end up in whatever step happens to be
> > before the pixel_tests step.
> 
> Please review https://codereview.chromium.org/295983010/.
> The install step is going away.

How about merging the two CLs? There is no advantage to keeping them separate if
they are going to land in quick succession.

[alokp, 2014-05-28 22:11:53]

Good idea! DONE.

navabi@: PTAL

[navabi, 2014-05-28 22:28:13]

lgtm

[alokp, 2014-05-28 22:37:48]

navabi: I think you need to lgtm from your chromium account,

[navabi1, 2014-05-28 22:59:54]

lgtm

[alokp, 2014-05-28 23:01:32]

Committed patchset #5 manually as r273386 (presubmit successful).