Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: android_webview/renderer/aw_content_renderer_client.cc

Issue 2799923003: Change SpellCheckProvider into a RenderFrameObserver (Closed)
Patch Set: Tue Apr 11 17:50:52 PDT 2017 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/chrome_content_renderer_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/renderer/aw_content_renderer_client.cc
diff --git a/android_webview/renderer/aw_content_renderer_client.cc b/android_webview/renderer/aw_content_renderer_client.cc
index a99d8bc0a65cd7a3e7394727b74b2a65c18df3e5..30aac4cf3f9af0c859a890788aefb35a76fe6f30 100644
--- a/android_webview/renderer/aw_content_renderer_client.cc
+++ b/android_webview/renderer/aw_content_renderer_client.cc
@@ -170,6 +170,10 @@ void AwContentRendererClient::RenderFrameCreated(
autofill::PasswordAutofillAgent* password_autofill_agent =
new autofill::PasswordAutofillAgent(render_frame);
new autofill::AutofillAgent(render_frame, password_autofill_agent, NULL);
+
+#if BUILDFLAG(ENABLE_SPELLCHECK)
+ new SpellCheckProvider(render_frame, spellcheck_.get());
+#endif
}
void AwContentRendererClient::RenderViewCreated(
@@ -177,7 +181,13 @@ void AwContentRendererClient::RenderViewCreated(
AwRenderViewExt::RenderViewCreated(render_view);
#if BUILDFLAG(ENABLE_SPELLCHECK)
- new SpellCheckProvider(render_view, spellcheck_.get());
+ // This is a workaround keeping the behavior that, the Blink side spellcheck
+ // enabled state is initialized on RenderView creation.
+ // TODO(xiaochengh): Design better way to sync between Chrome-side and
+ // Blink-side spellcheck enabled states. See crbug.com/710097.
+ if (SpellCheckProvider* provider =
+ SpellCheckProvider::Get(render_view->GetMainRenderFrame()))
+ provider->EnableSpellcheck(spellcheck_->IsSpellcheckEnabled());
#endif
}
« no previous file with comments | « no previous file | chrome/renderer/chrome_content_renderer_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698