third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2799923003: Change SpellCheckProvider into a RenderFrameObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2799923003: Change SpellCheckProvider into a RenderFrameObserver (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index b04cd1c097701ec218b35073b1dbb74a91785b8f..c28c39528ccc7e12d6cd30a5845c1b185ad3eb52 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -1074,6 +1074,7 @@ bool WebLocalFrameImpl::isCommandEnabled(const WebString& name) const {

}

void WebLocalFrameImpl::enableSpellChecking(bool enable) {

+ CHECK(frame());

Xiaocheng 2017/04/07 01:43:46 Crash site.

if (enable == isSpellCheckingEnabled())

return;

frame()->spellChecker().toggleSpellCheckingEnabled();