Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: src/ia32/assembler-ia32.cc

Issue 2799863002: [Atomics] use TFJ builtins for atomic add, sub, and, or, and xor (Closed)
Patch Set: [Atomics] use TFJ builtins for atomic add, sub, and, or, and xor Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ia32/assembler-ia32.cc
diff --git a/src/ia32/assembler-ia32.cc b/src/ia32/assembler-ia32.cc
index bb69cff8ab1eacb96e044e04dc12bae6c1a00054..11750a395d388cff7a954704c025a1607a1f5df9 100644
--- a/src/ia32/assembler-ia32.cc
+++ b/src/ia32/assembler-ia32.cc
@@ -708,6 +708,7 @@ void Assembler::xchg(Register dst, const Operand& src) {
}
void Assembler::xchg_b(Register reg, const Operand& op) {
+ DCHECK(reg.is_byte_register());
EnsureSpace ensure_space(this);
EMIT(0x86);
emit_operand(reg, op);
@@ -733,6 +734,7 @@ void Assembler::cmpxchg(const Operand& dst, Register src) {
}
void Assembler::cmpxchg_b(const Operand& dst, Register src) {
+ DCHECK(src.is_byte_register());
EnsureSpace ensure_space(this);
EMIT(0x0F);
EMIT(0xB0);

Powered by Google App Engine
This is Rietveld 408576698