Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: src/compiler/machine-graph-verifier.cc

Issue 2799863002: [Atomics] use TFJ builtins for atomic add, sub, and, or, and xor (Closed)
Patch Set: [Atomics] use TFJ builtins for atomic add, sub, and, or, and xor Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/machine-graph-verifier.cc
diff --git a/src/compiler/machine-graph-verifier.cc b/src/compiler/machine-graph-verifier.cc
index f39882c4c95b066d60fd5750a826a7f076611231..6ac7a163e1079a6a13b42c391975d5f4b048a032 100644
--- a/src/compiler/machine-graph-verifier.cc
+++ b/src/compiler/machine-graph-verifier.cc
@@ -149,13 +149,14 @@ class MachineRepresentationInferrer {
PromoteRepresentation(AtomicStoreRepresentationOf(node->op()));
break;
case IrOpcode::kAtomicExchange:
- representation_vector_[node->id()] = PromoteRepresentation(
- AtomicExchangeRepresentationOf(node->op()).representation());
- break;
case IrOpcode::kAtomicCompareExchange:
+ case IrOpcode::kAtomicAdd:
+ case IrOpcode::kAtomicSub:
+ case IrOpcode::kAtomicAnd:
+ case IrOpcode::kAtomicOr:
+ case IrOpcode::kAtomicXor:
representation_vector_[node->id()] = PromoteRepresentation(
- AtomicCompareExchangeRepresentationOf(node->op())
- .representation());
+ AtomicOpRepresentationOf(node->op()).representation());
break;
case IrOpcode::kStore:
case IrOpcode::kProtectedStore:
@@ -455,6 +456,11 @@ class MachineRepresentationChecker {
case IrOpcode::kStore:
case IrOpcode::kAtomicStore:
case IrOpcode::kAtomicExchange:
+ case IrOpcode::kAtomicAdd:
+ case IrOpcode::kAtomicSub:
+ case IrOpcode::kAtomicAnd:
+ case IrOpcode::kAtomicOr:
+ case IrOpcode::kAtomicXor:
CheckValueInputIsTaggedOrPointer(node, 0);
CheckValueInputRepresentationIs(
node, 1, MachineType::PointerRepresentation());

Powered by Google App Engine
This is Rietveld 408576698