Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(22)

Issue 2799783008: Implementation of preserveDrawingBuffer:Discard in software (Closed)

Created:
1 year, 6 months ago by sugoi1
Modified:
1 year ago
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, fmalita+watch_chromium.org, Rik, Justin Novosad, blink-reviews, piman+watch_chromium.org, kinuko+watch, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implementation of preserveDrawingBuffer:Discard in software DrawingBuffer::finishPrepareTextureMailboxSoftware was ignoring the m_preserveDrawingBuffer setting, so this change adds a simple clear operation to emulate that behavior in software. Related tests from the WebGL Conformance Tests 1.0.4 test suite all pass. Tests are: conformance/canvas/buffer-offscreen-test.html conformance/canvas/buffer-preserve-test.html conformance/context/context-attribute-preserve-drawing-buffer.html BUG=709622 R=kbr@chromium.org Review-Url: https://codereview.chromium.org/2799783008 Cr-Commit-Position: refs/heads/master@{#463132} Committed: https://chromium.googlesource.com/chromium/src/+/154a93d5c03f1a483b644c1bca4dea60dabb7dad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sugoi1
This should hopefully be the last chromium side change required to get SwiftShader to fully ...
1 year, 6 months ago (2017-04-07 21:16:34 UTC) #3
Ken Russell (switch to Gerrit)
Nice. LGTM
1 year, 6 months ago (2017-04-08 00:03:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799783008/1
1 year, 6 months ago (2017-04-08 13:33:14 UTC) #8
commit-bot: I haz the power
1 year, 6 months ago (2017-04-08 13:37:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/154a93d5c03f1a483b644c1bca4d...

Powered by Google App Engine
This is Rietveld 408576698