Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: components/cronet/android/test/javaperftests/android_rndis_forwarder.py

Issue 2799743009: [Cronet] Get Cronet's javaperftest running again (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/android/test/javaperftests/run.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javaperftests/android_rndis_forwarder.py
diff --git a/components/cronet/android/test/javaperftests/android_rndis_forwarder.py b/components/cronet/android/test/javaperftests/android_rndis_forwarder.py
index f4f5364ea62cd7b9e2403ca5bf831686a7c4feb6..4c5a3b0396c5838ce451ce4872bdb3423fa183e8 100644
--- a/components/cronet/android/test/javaperftests/android_rndis_forwarder.py
+++ b/components/cronet/android/test/javaperftests/android_rndis_forwarder.py
@@ -28,7 +28,9 @@ class AndroidRndisForwarder(object):
self._host_ip = rndis_configurator.host_ip
self._original_dns = None, None, None
self._RedirectPorts()
- self._OverrideDns()
+ # The netd commands fail on Lollipop and newer releases, but aren't
+ # necessary as DNS isn't used.
+ # self._OverrideDns()
self._OverrideDefaultGateway()
# Need to override routing policy again since call to setifdns
# sometimes resets policy table
« no previous file with comments | « no previous file | components/cronet/android/test/javaperftests/run.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698