Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 279973005: crypto: Add ECPrivateKey::Copy (not needed for OpenSSL) and (Closed)

Created:
6 years, 7 months ago by wtc
Modified:
6 years, 6 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

crypto: Add ECPrivateKey::Copy (not needed for OpenSSL) and ECPrivateKey::ExportRawPublicKey. R=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279308

Patch Set 1 #

Patch Set 2 : Upload a checkpoint #

Patch Set 3 : First complete milestone #

Patch Set 4 : #

Patch Set 5 : Rebase #

Patch Set 6 : Minor tweaks #

Patch Set 7 : Make QUIC ChannelID unit test work, by adding Mock ProofSource and ProofVerifier #

Total comments: 10

Patch Set 8 : Address rsleevi comments #

Total comments: 12

Patch Set 9 : Keep only crypto changes and rebase #

Patch Set 10 : Use SECKEY_GetPublicKeyType #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -10 lines) Patch
M crypto/ec_private_key.h View 1 2 3 4 5 6 7 8 2 chunks +6 lines, -0 lines 0 comments Download
M crypto/ec_private_key_nss.cc View 1 2 3 4 5 6 7 8 9 5 chunks +43 lines, -1 line 0 comments Download
M crypto/ec_private_key_openssl.cc View 1 2 3 4 5 6 7 8 3 chunks +22 lines, -1 line 0 comments Download
M crypto/ec_private_key_unittest.cc View 1 2 3 4 5 6 7 8 3 chunks +47 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
wtc
rch,rtenneti: Please review everything. rsleevi: you just need to review crypto and net/quic/test_tools/crypto_test_utils_nss.cc. crypto_test_utils_nss.cc shows ...
6 years, 6 months ago (2014-06-18 01:36:02 UTC) #1
Ryan Sleevi
https://codereview.chromium.org/279973005/diff/120001/crypto/ec_private_key_nss.cc File crypto/ec_private_key_nss.cc (right): https://codereview.chromium.org/279973005/diff/120001/crypto/ec_private_key_nss.cc#newcode195 crypto/ec_private_key_nss.cc:195: &(*public_key)->u.ec.publicValue, Have I missed something? It seems like we ...
6 years, 6 months ago (2014-06-18 01:50:36 UTC) #2
wtc
rsleevi: thanks a lot for the review. Please review patch set 8. https://codereview.chromium.org/279973005/diff/120001/crypto/ec_private_key_nss.cc File crypto/ec_private_key_nss.cc ...
6 years, 6 months ago (2014-06-19 23:53:52 UTC) #3
Ryan Sleevi
Are the CHECKs() correct? That is, by making it CHECK(), you're explicitly saying it can ...
6 years, 6 months ago (2014-06-20 00:59:40 UTC) #4
wtc
On 2014/06/20 00:59:40, Ryan Sleevi wrote: > Are the CHECKs() correct? I annotated all the ...
6 years, 6 months ago (2014-06-20 01:45:42 UTC) #5
Ryan Sleevi
crypto/ LGTM
6 years, 6 months ago (2014-06-23 22:49:29 UTC) #6
wtc
Ryan: thanks for the review. I created a new CL https://codereview.chromium.org/346323002/ for the actual QUIC ...
6 years, 6 months ago (2014-06-24 01:43:36 UTC) #7
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 6 months ago (2014-06-24 01:43:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/279973005/180001
6 years, 6 months ago (2014-06-24 01:44:59 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 04:12:43 UTC) #10
Message was sent while issue was closed.
Change committed as 279308

Powered by Google App Engine
This is Rietveld 408576698