third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py - Issue 2799683003: Add skip expectations for new manual tests with a missing or timeout result.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py

Issue 2799683003: Add skip expectations for new manual tests with a missing or timeout result. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py

index f40df9e19a635879a069ac02fe0cbceb74a96f73..9e036d219e8b816f5ef45ca13e3a304716e4326a 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py

@@ -466,3 +466,27 @@ class WPTExpectationsUpdaterTest(LoggingTestCase):

updater.get_latest_try_jobs = lambda: []

self.assertEqual(1, updater.run(args=[]))

self.assertLog(['ERROR: No try job information was collected.\n'])

+ def test_new_manual_tests_get_skip_expectation(self):

+ host = self.mock_host()

+ host.filesystem.write_text_file('/mock-checkout/third_party/WebKit/LayoutTests/external/wpt/x-manual.html', '<html>')

+ updater = WPTExpectationsUpdater(host)

+ results = {

+ 'external/wpt/x-manual.html': {

+ (

+ 'test-linux-precise',

+ 'test-linux-trusty',

+ 'test-mac-mac10.10',

+ 'test-mac-mac10.11',

+ 'test-win-win7',

+ 'test-win-win10',

+ ): {'expected': 'PASS', 'actual': 'MISSING', 'bug': 'crbug.com/test'}

+ }

+ results_copy = copy.deepcopy(results)

+ self.assertEqual(

+ updater.get_tests_to_rebaseline(results),

+ ([], results_copy))

+ self.assertEqual(

+ updater.create_line_list(results),

+ ['crbug.com/test external/wpt/x-manual.html [ Skip ]'])

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py ('k') | no next file » | no next file with comments »