Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: components/sync/driver/shared_change_processor.h

Issue 2799653006: Revert of [Sync] Stop accessing BrowserContextKeyedServiceFactory on non-UI thread. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/driver/shared_change_processor.h
diff --git a/components/sync/driver/shared_change_processor.h b/components/sync/driver/shared_change_processor.h
index 05755f8c35e778620915a903b794552bc8a0915c..280ad5e2be112469e285fa5292498e6323535c76 100644
--- a/components/sync/driver/shared_change_processor.h
+++ b/components/sync/driver/shared_change_processor.h
@@ -16,7 +16,6 @@
#include "base/single_thread_task_runner.h"
#include "base/synchronization/lock.h"
#include "components/sync/driver/data_type_controller.h"
-#include "components/sync/driver/sync_client.h"
#include "components/sync/engine/model_safe_worker.h"
#include "components/sync/model/data_type_error_handler.h"
#include "components/sync/model/sync_change_processor.h"
@@ -30,7 +29,7 @@
class ChangeProcessor;
class GenericChangeProcessor;
class GenericChangeProcessorFactory;
-class SyncApiComponentFactory;
+class SyncClient;
class SyncableService;
struct UserShare;
@@ -62,9 +61,8 @@
// Create an uninitialized SharedChangeProcessor.
explicit SharedChangeProcessor(ModelType type);
- void StartAssociation(const StartDoneCallback& start_done,
- const SyncClient::ServiceProvider& service_provider,
- SyncApiComponentFactory* driver_factory,
+ void StartAssociation(StartDoneCallback start_done,
+ SyncClient* const sync_client,
GenericChangeProcessorFactory* processor_factory,
UserShare* user_share,
std::unique_ptr<DataTypeErrorHandler> error_handler);
@@ -73,10 +71,9 @@
// create and store a new GenericChangeProcessor and return a weak pointer to
// the SyncableService associated with |type|.
// Note: If this SharedChangeProcessor has been disconnected, or the
- // SyncableService is not alive, will return a null weak pointer.
+ // SyncableService was not alive, will return a null weak pointer.
virtual base::WeakPtr<SyncableService> Connect(
- const SyncClient::ServiceProvider& service_provider,
- SyncApiComponentFactory* driver_factory,
+ SyncClient* sync_client,
GenericChangeProcessorFactory* processor_factory,
UserShare* user_share,
std::unique_ptr<DataTypeErrorHandler> error_handler,
« no previous file with comments | « components/sync/driver/generic_change_processor_unittest.cc ('k') | components/sync/driver/shared_change_processor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698